[PATCH] drm/xe/device: fix drm_WARN_ON() check

Nirmoy Das nirmoy.das at intel.com
Mon Mar 18 11:39:52 UTC 2024


On 3/18/2024 12:37 PM, Matthew Auld wrote:
> Here XE_MAX_TILES_PER_DEVICE is the gt array size, therefore the gt
> index should always be less than.
>
> Signed-off-by: Matthew Auld<matthew.auld at intel.com>
> Cc: Nirmoy Das<nirmoy.das at intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>
> ---
>   drivers/gpu/drm/xe/xe_device.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index 14be34d9f543..6b32f09a4c89 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -79,7 +79,7 @@ static inline struct xe_gt *xe_device_get_gt(struct xe_device *xe, u8 gt_id)
>   	if (MEDIA_VER(xe) >= 13) {
>   		gt = xe_tile_get_gt(root_tile, gt_id);
>   	} else {
> -		if (drm_WARN_ON(&xe->drm, gt_id > XE_MAX_TILES_PER_DEVICE))
> +		if (drm_WARN_ON(&xe->drm, gt_id >= XE_MAX_TILES_PER_DEVICE))
>   			gt_id = 0;
>   
>   		gt = xe->tiles[gt_id].primary_gt;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20240318/72fafad2/attachment.htm>


More information about the Intel-xe mailing list