[PATCH] drm/xe/gt: Remove continue statement which has no effect

[Daniele Ceraolo Spurio]

On 3/18/2024 7:48 AM, Lucas De Marchi wrote:
> On Mon, Mar 18, 2024 at 05:10:57PM +0530, Tejas Upadhyay wrote:
>> Remove continue statement which does not have real effect
>> as no actions are to be taken post continue.
>>
>> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>
> as this comes from commit 3d2b5d4e28d9 ("drm/xe: add GSCCS irq support")
>
> apparently we needed to invert the check for class since GSCCS is
> OTHER_CLASS, but it's expected to return a hwe from xe_gt_hw_engine().

I simply didn't remove a "continue" that was already there when I 
removed the last statement after it. My idea was that this way we 
wouldn't risk forgetting to add it back if we ever add something new 
again at the end of that loop. I'd prefer to keep it in for that reason, 
but CI should catch eventual problem so I'm ok with it being removed if 
you think it makes the code cleaner.

Daniele

>
> Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/xe/xe_irq.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
>> index 2275ca35a3c7..996806353171 100644
>> --- a/drivers/gpu/drm/xe/xe_irq.c
>> +++ b/drivers/gpu/drm/xe/xe_irq.c
>> @@ -326,7 +326,6 @@ static void gt_irq_handler(struct xe_tile *tile,
>>                     xe_heci_gsc_irq_handler(xe, intr_vec);
>>                 else
>>                     gt_other_irq_handler(engine_gt, instance, intr_vec);
>> -                continue;
>>             }
>>         }
>>     }
>> -- 
>> 2.25.1
>>