[PATCH 2/3] drm/xe/device: fix XE_MAX_GT_PER_TILE check

Nirmoy Das nirmoy.das at intel.com
Mon Mar 18 18:42:48 UTC 2024


On 3/18/2024 7:05 PM, Matthew Auld wrote:
> Here XE_MAX_GT_PER_TILE is the total, therefore the gt index should
> always be less than.
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Matthew Auld<matthew.auld at intel.com>
> Cc: Nirmoy Das<nirmoy.das at intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

> ---
>   drivers/gpu/drm/xe/xe_device.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index 14be34d9f543..5c254ec9c602 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -58,7 +58,7 @@ static inline struct xe_tile *xe_device_get_root_tile(struct xe_device *xe)
>   
>   static inline struct xe_gt *xe_tile_get_gt(struct xe_tile *tile, u8 gt_id)
>   {
> -	if (drm_WARN_ON(&tile_to_xe(tile)->drm, gt_id > XE_MAX_GT_PER_TILE))
> +	if (drm_WARN_ON(&tile_to_xe(tile)->drm, gt_id >= XE_MAX_GT_PER_TILE))
>   		gt_id = 0;
>   
>   	return gt_id ? tile->media_gt : tile->primary_gt;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20240318/2c345db8/attachment.htm>


More information about the Intel-xe mailing list