✓ CI.checkpatch: success for drm/xe: Always check force_wake_get return code (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Mon Mar 18 21:57:39 UTC 2024
== Series Details ==
Series: drm/xe: Always check force_wake_get return code (rev2)
URL : https://patchwork.freedesktop.org/series/131045/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 441d3cb41c0282e3bfb0d6b72299ebb3e4c0ec6d
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date: Mon Mar 18 08:49:24 2024 -0700
drm/xe: Always check force_wake_get return code
A force_wake_get failure means that the HW might not be awake for the
access we're doing; this can lead to an immediate error or it can be a
more subtle problem (e.g. a register read might return an incorrect
value that is still valid, leading the driver to make a wrong choice
instead of flagging an error).
We avoid an error from the force_wake function because callers might
handle or tolerate the error, but this only works if all callers
are checking the error code. The majority already do, but a few are not.
These are mainly falling into 3 categories, which are each handled
differently:
1) error capture: in this case we want to continue the capture, but we
log an info message in dmesg to notify the user that the capture
might have incorrect data.
2) ioctl: in this case we return a -EIO error to userspace
3) unabortable actions: these are scenarios where we can't simply abort
and retry and so it's better to just try it anyway because there is a
chance the HW is awake even with the failure. In this case we throw a
warning so we know there was a forcewake problem if something fails
down the line.
v2: use gt_WARN_ON where appropriate
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay at intel.com>
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
+ /mt/dim checkpatch ce8cc731d53f9197a853b0d00386d7835f2b80e6 drm-intel
441d3cb41c02 drm/xe: Always check force_wake_get return code
More information about the Intel-xe
mailing list