✗ CI.checkpatch: warning for drm/xe/guc: Add GuC based register capture for error capture (rev5)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Add GuC based register capture for error capture (rev5)
URL   : https://patchwork.freedesktop.org/series/128077/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4a5dc64ac2215807005b902b8e30158ba7c9e43b
Author: Zhanjun Dong <zhanjun.dong at intel.com>
Date:   Tue Mar 19 07:36:21 2024 -0700

    drm/xe/guc: Plumb GuC-capture into dev coredump
    
    Add xe_hw_engine_snapshot_from_capture to take snapshot from capture
    node list.
    Add data struct to map register to a snapshot field, although all
    field is mapped now, which means the offset could be optimized out,
    while in the future, depends on system configuration, the field might
    not be consecutive, keep the offset is reserved for future.
    
    Signed-off-by: Zhanjun Dong <zhanjun.dong at intel.com>
+ /mt/dim checkpatch a62a45162bdd12e161462000ba79151cd3422052 drm-intel
2ce63c414c9c drm/xe/guc: Add kconfig for GuC based register capture
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:72: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#72: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 102 lines checked
1ec393cc88ea drm/xe/guc: Update GuC ADS size for error capture
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:251: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#251: FILE: drivers/gpu/drm/xe/xe_guc_ads.c:562:
+								 GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE,

-:369: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ar' - possible side-effects?
#369: FILE: drivers/gpu/drm/xe/xe_guc_capture.c:54:
+#define get_item_with_default(ar, index) (ar[(index) >= ARRAY_SIZE(ar) ? ARRAY_SIZE(ar) -  1 : \
+									 (index)])

-:369: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#369: FILE: drivers/gpu/drm/xe/xe_guc_capture.c:54:
+#define get_item_with_default(ar, index) (ar[(index) >= ARRAY_SIZE(ar) ? ARRAY_SIZE(ar) -  1 : \
+									 (index)])

-:554: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#554: FILE: drivers/gpu/drm/xe/xe_guc_capture.c:239:
+	if (!caplist) {
+		xe_gt_dbg(guc_to_gt(guc), "Failed to alloc cached register capture list");

-:594: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#594: FILE: drivers/gpu/drm/xe/xe_guc_capture.c:279:
+	if (!null_header) {
+		xe_gt_dbg(guc_to_gt(guc), "Failed to alloc cached register capture null list");

-:639: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#639: 
new file mode 100644

total: 0 errors, 4 warnings, 2 checks, 812 lines checked
2685d02776a7 drm/xe/guc: Add XE_LP steered register lists
-:52: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#52: FILE: drivers/gpu/drm/xe/xe_guc_capture.c:43:
+#define COMMON_BASE_ENGINE_INSTANCE \
+	{ RING_ESR(0),              0,      0, "ESR" }, \
+	{ RING_EMR(0),              0,      0, "EMR" }, \
+	{ RING_EIR(0),              0,      0, "EIR" }, \
+	{ RING_EXECLIST_STATUS_HI(0), 0,    0, "RING_EXECLIST_STATUS_HI" }, \
+	{ RING_EXECLIST_STATUS_LO(0), 0,    0, "RING_EXECLIST_STATUS_LO" }, \
+	{ RING_DMA_FADD(0),         0,      0, "RING_DMA_FADD_LDW" }, \
+	{ RING_DMA_FADD_UDW(0),     0,      0, "RING_DMA_FADD_UDW" }, \
+	{ RING_IPEHR(0),            0,      0, "IPEHR" }, \
+	{ RING_BBADDR(0),           0,      0, "RING_BBADDR_LOW32" }, \
+	{ RING_BBADDR_UDW(0),       0,      0, "RING_BBADDR_UP32" }, \
+	{ RING_ACTHD(0),            0,      0, "ACTHD_LDW" }, \
+	{ RING_ACTHD_UDW(0),        0,      0, "ACTHD_UDW" }, \
+	{ RING_START(0),            0,      0, "START" }, \
+	{ RING_HEAD(0),             0,      0, "HEAD" }, \
+	{ RING_TAIL(0),             0,      0, "TAIL" }, \
+	{ RING_CTL(0),              0,      0, "CTL" }, \
+	{ RING_MI_MODE(0),          0,      0, "MODE" }, \
+	{ RING_HWS_PGA(0),          0,      0, "HWS" }, \
+	{ RING_MODE(0),             0,      0, "GFX_MODE" }

-:112: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'regslist' - possible side-effects?
#112: FILE: drivers/gpu/drm/xe/xe_guc_capture.c:103:
+#define MAKE_REGLIST(regslist, regsowner, regstype, class) \
+	{ \
+		regslist, \
+		ARRAY_SIZE(regslist), \
+		TO_GCAP_DEF_OWNER(regsowner), \
+		TO_GCAP_DEF_TYPE(regstype), \
+		class, \
+		NULL, \
+	}

total: 1 errors, 0 warnings, 1 checks, 241 lines checked
db774a661d9d drm/xe/guc: Add capture size check in GuC log buffer
a6bfb41e1199 drm/xe/guc: Check sizing of guc_capture output
3c13d98be09c drm/xe/guc: Extract GuC error capture lists on G2H notification
bb8263f05809 drm/xe/guc: Pre-allocate output nodes for extraction
4a5dc64ac221 drm/xe/guc: Plumb GuC-capture into dev coredump