✗ CI.checkpatch: warning for Change userptr so it can be unified with hmmptr

[Patchwork]

== Series Details ==

Series: Change userptr so it can be unified with hmmptr
URL   : https://patchwork.freedesktop.org/series/131398/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c542b552c210f7679d844e9e5a559d792cb8850f
Author: Oak Zeng <oak.zeng at intel.com>
Date:   Wed Mar 20 22:29:39 2024 -0400

    drm/xe: destroy userptr vma on UNMAP event
    
    When there is MMU_NOTIFY_UNMAP event happens, the userptr
    is munmapped from CPU. There is no need to keep the xe_vma
    for this userptr from GPU side. So we destroy it.
    
    But we can't destroy vma directly from the mmu notifier
    callback function, because we need to remove mmu
    notifier during vma destroy. If we remove mmu notifier
    directly from mmu notifier callback, it is a deadlock.
    xe_vma_destroy is modified to destroy vma in a worker
    thread.
    
    Another reason of this change is, for the future
    hmmptr codes, we destroy vma when hmmptr is unmapped
    from CPU. We want to unify the hmmptr and userptr
    code.
    
    I believe this is also the correct behavior for userptr.
    This patch is experimental for CI and open to discuss
    
    Signed-off-by: Oak Zeng <oak.zeng at intel.com>
+ /mt/dim checkpatch b8290992108644cb99d7d9db2921bb25369ead3c drm-intel
62864dd4cf3b drm/xe: Introduce helper to populate userptr
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

-:152: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#152: FILE: drivers/gpu/drm/xe/xe_hmm.c:80:
+static int xe_build_sg(struct xe_device *xe, struct hmm_range *range,
+			     struct sg_table *st, bool write)

-:170: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#170: FILE: drivers/gpu/drm/xe/xe_hmm.c:98:
+	ret = sg_alloc_table_from_pages_segment(st, pages, npages, 0,
+			npages << PAGE_SHIFT, xe_sg_segment_size(dev), GFP_KERNEL);

-:175: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#175: FILE: drivers/gpu/drm/xe/xe_hmm.c:103:
+	ret = dma_map_sgtable(dev, st, write ? DMA_BIDIRECTIONAL : DMA_TO_DEVICE,
+			DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_NO_KERNEL_MAPPING);

-:303: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/xe/xe_hmm.h', please use '/*' instead
#303: FILE: drivers/gpu/drm/xe/xe_hmm.h:1:
+// SPDX-License-Identifier: MIT

-:303: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#303: FILE: drivers/gpu/drm/xe/xe_hmm.h:1:
+// SPDX-License-Identifier: MIT

total: 0 errors, 3 warnings, 3 checks, 256 lines checked
1297b94e84b9 drm/xe: Introduce a helper to free sg table
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/xe/xe_hmm.c:131:
+	dma_unmap_sgtable(dev, userptr->sg,
+			write ? DMA_BIDIRECTIONAL : DMA_TO_DEVICE, 0);

total: 0 errors, 0 warnings, 1 checks, 52 lines checked
499747afa3cc drm/xe: Use hmm_range_fault to populate user pages
c542b552c210 drm/xe: destroy userptr vma on UNMAP event