[PATCH 6/6] drm/xe: Introduce the busted_mode debugfs

Lucas De Marchi lucas.demarchi at intel.com
Thu Mar 21 13:16:18 UTC 2024


On Mon, Mar 18, 2024 at 04:14:04PM -0400, Rodrigo Vivi wrote:
>On Mon, Mar 18, 2024 at 02:31:31PM -0500, Lucas De Marchi wrote:
>> On Fri, Mar 15, 2024 at 10:01:08AM -0400, Rodrigo Vivi wrote:
>> > So, the busted mode can be selected at runtime with the device
>> > granularity, rather then a module policy.
>>
>> did you mean to squash this in the previous commit?
>
>doh! yes, that was the intention, but forgot to mark it as a fixup.
>
>>
>> for the entire series, it seems it's going the right direction. It would
>> be good to have some more testing with it before merging though. I asked
>> SV folks to give it a try. I also saw some typos I forgot to comment on
>> so I will have to go through the patches again.
>
>yeap, I also want their ack on that as well.
>
>>
>> Another question is about naming since some people didn't like "busted".
>> Options:
>>
>> 1) keep busted
>> 2) zombie
>> 3) back to wedged
>> 4) dead
>> 5) blocked
>> 6) disabled
>> 7) unusable
>> 8) unreliable
>> 9) misbehaving
>>
>> Did I miss any suggestion?  Well.... the order above is just _my_
>> preference, but I'm totally fine if other people disagree and we decide
>> something else.
>>
>> Cc'ing some people who may chime in with their preference.
>
>well, at this point anything works to me. Just let me know the most popular
>and I change the patches.

wedged it is. Can you go back to wedged? Sorry for the trouble caused by
my dislike of using that word. Multiple people expressed a sentiment
like "better the devil you know".

one thing that I had considered before was grepping for wedged 
in other drivers. Although every driver seems to have slightly different
semantic for a wedged state, we certainly have more "wedged state" than
busted, zombie, etc. So... let's just go back to what you had before.


Lucas De Marchi


More information about the Intel-xe mailing list