[PATCH] drm/xe/guc: Add some failure checks
Rodrigo Vivi
rodrigo.vivi at intel.com
Thu Mar 21 19:48:53 UTC 2024
On Thu, Mar 21, 2024 at 12:12:19PM -0700, Vinay Belgaumkar wrote:
> Return failures from pc_adjust_freq_bounds.
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_pc.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 6dfae1c23946..9c110537d135 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -695,24 +695,28 @@ static int pc_adjust_freq_bounds(struct xe_guc_pc *pc)
>
> ret = pc_action_query_task_state(pc);
> if (ret)
> - return ret;
> + goto out;
>
> /*
> * GuC defaults to some RPmax that is not actually achievable without
> * overclocking. Let's adjust it to the Hardware RP0, which is the
> * regular maximum
> */
> - if (pc_get_max_freq(pc) > pc->rp0_freq)
> - pc_set_max_freq(pc, pc->rp0_freq);
> + if (pc_get_max_freq(pc) > pc->rp0_freq) {
> + ret = pc_set_max_freq(pc, pc->rp0_freq);
> + if (ret)
> + goto out;
> + }
>
> /*
> * Same thing happens for Server platforms where min is listed as
> * RPMax
> */
> if (pc_get_min_freq(pc) > pc->rp0_freq)
> - pc_set_min_freq(pc, pc->rp0_freq);
> + ret = pc_set_min_freq(pc, pc->rp0_freq);
>
> - return 0;
> +out:
> + return ret;
> }
>
> static int pc_adjust_requested_freq(struct xe_guc_pc *pc)
> --
> 2.38.1
>
More information about the Intel-xe
mailing list