[PATCH v3 1/2] drm/xe: prefer snprintf over sprintf

[Ghimiray, Himal Prasad]

> -----Original Message-----
> From: Bommu, Krishnaiah <krishnaiah.bommu at intel.com>
> Sent: 07 December 2023 06:59
> To: intel-xe at lists.freedesktop.org
> Cc: Bommu, Krishnaiah <krishnaiah.bommu at intel.com>; Ghimiray, Himal
> Prasad <himal.prasad.ghimiray at intel.com>; Upadhyay, Tejas
> <tejas.upadhyay at intel.com>
> Subject: [PATCH v3 1/2] drm/xe: prefer snprintf over sprintf
> 
> Static analyzer Reported "Calling risky function (DC.STRING_BUFFER)”
> 
> v2: Removed hard coded values abd used sizeof()

Typo: /s/abd/and 

> 
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> Cc: Tejas Upadhyay <tejas.upadhyay at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_debugfs.c    |  2 +-
>  drivers/gpu/drm/xe/xe_exec_queue.c | 12 ++++++------
> drivers/gpu/drm/xe/xe_gt_debugfs.c |  2 +-
>  drivers/gpu/drm/xe/xe_gt_idle.c    |  4 ++--
>  drivers/gpu/drm/xe/xe_hw_fence.c   |  2 +-
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_debugfs.c
> b/drivers/gpu/drm/xe/xe_debugfs.c index 8abdf3c17e1d..86150cafe0ff
> 100644
> --- a/drivers/gpu/drm/xe/xe_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> @@ -129,7 +129,7 @@ void xe_debugfs_register(struct xe_device *xe)
>  		if (man) {
>  			char name[16];
> 
> -			sprintf(name, "vram%d_mm", mem_type -
> XE_PL_VRAM0);
> +			snprintf(name, sizeof(name), "vram%d_mm",
> mem_type - XE_PL_VRAM0);
>  			ttm_resource_manager_create_debugfs(man, root,
> name);
>  		}
>  	}
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c
> b/drivers/gpu/drm/xe/xe_exec_queue.c
> index 730eb7d2a639..71bd52dfebcf 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -225,22 +225,22 @@ void xe_exec_queue_assign_name(struct
> xe_exec_queue *q, u32 instance)  {
>  	switch (q->class) {
>  	case XE_ENGINE_CLASS_RENDER:
> -		sprintf(q->name, "rcs%d", instance);
> +		snprintf(q->name, sizeof(q->name), "rcs%d", instance);
>  		break;
>  	case XE_ENGINE_CLASS_VIDEO_DECODE:
> -		sprintf(q->name, "vcs%d", instance);
> +		snprintf(q->name, sizeof(q->name), "vcs%d", instance);
>  		break;
>  	case XE_ENGINE_CLASS_VIDEO_ENHANCE:
> -		sprintf(q->name, "vecs%d", instance);
> +		snprintf(q->name, sizeof(q->name), "vecs%d", instance);
>  		break;
>  	case XE_ENGINE_CLASS_COPY:
> -		sprintf(q->name, "bcs%d", instance);
> +		snprintf(q->name, sizeof(q->name), "bcs%d", instance);
>  		break;
>  	case XE_ENGINE_CLASS_COMPUTE:
> -		sprintf(q->name, "ccs%d", instance);
> +		snprintf(q->name, sizeof(q->name), "ccs%d", instance);
>  		break;
>  	case XE_ENGINE_CLASS_OTHER:
> -		sprintf(q->name, "gsccs%d", instance);
> +		snprintf(q->name, sizeof(q->name), "gsccs%d", instance);
>  		break;
>  	default:
>  		XE_WARN_ON(q->class);
> diff --git a/drivers/gpu/drm/xe/xe_gt_debugfs.c
> b/drivers/gpu/drm/xe/xe_gt_debugfs.c
> index 6b4dc2927727..3af85b2f6625 100644
> --- a/drivers/gpu/drm/xe/xe_gt_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_gt_debugfs.c
> @@ -261,7 +261,7 @@ void xe_gt_debugfs_register(struct xe_gt *gt)
> 
>  	xe_gt_assert(gt, minor->debugfs_root);
> 
> -	sprintf(name, "gt%d", gt->info.id);
> +	snprintf(name, sizeof(name), "gt%d", gt->info.id);
>  	root = debugfs_create_dir(name, minor->debugfs_root);
>  	if (IS_ERR(root)) {
>  		drm_warn(&xe->drm, "Create GT directory failed"); diff --git
> a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c index
> 2984680de3f9..bc1426f8d731 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.c
> @@ -166,10 +166,10 @@ void xe_gt_idle_sysfs_init(struct xe_gt_idle *gtidle)
>  	}
> 
>  	if (xe_gt_is_media_type(gt)) {
> -		sprintf(gtidle->name, "gt%d-mc", gt->info.id);
> +		snprintf(gtidle->name, sizeof(gtidle->name), "gt%d-mc", gt-
> >info.id);
>  		gtidle->idle_residency = xe_guc_pc_mc6_residency;
>  	} else {
> -		sprintf(gtidle->name, "gt%d-rc", gt->info.id);
> +		snprintf(gtidle->name, sizeof(gtidle->name), "gt%d-rc", gt-
> >info.id);
>  		gtidle->idle_residency = xe_guc_pc_rc6_residency;
>  	}
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_fence.c
> b/drivers/gpu/drm/xe/xe_hw_fence.c
> index a5de3e7b0bd6..f872ef103127 100644
> --- a/drivers/gpu/drm/xe/xe_hw_fence.c
> +++ b/drivers/gpu/drm/xe/xe_hw_fence.c
> @@ -130,7 +130,7 @@ void xe_hw_fence_ctx_init(struct xe_hw_fence_ctx
> *ctx, struct xe_gt *gt,
>  	ctx->irq = irq;
>  	ctx->dma_fence_ctx = dma_fence_context_alloc(1);
>  	ctx->next_seqno = XE_FENCE_INITIAL_SEQNO;
> -	sprintf(ctx->name, "%s", name);
> +	snprintf(ctx->name, sizeof(ctx->name), "%s", name);

With typo addressed. LGTM
Reviewed-by: Himal Prasad Ghimiray<himal.prasad.ghimiray at intel.com>

>  }
> 
>  void xe_hw_fence_ctx_finish(struct xe_hw_fence_ctx *ctx)
> --
> 2.25.1