[PATCH] drm/xe: Fix static analysis tool reported errors

[Gupta, Anshuman]

> -----Original Message-----
> From: Poosa, Karthik <karthik.poosa at intel.com>
> Sent: Saturday, March 23, 2024 4:23 PM
> To: intel-xe at lists.freedesktop.org
> Cc: Gupta, Anshuman <anshuman.gupta at intel.com>; Nilawar, Badal
> <badal.nilawar at intel.com>; Poosa, Karthik <karthik.poosa at intel.com>
> Subject: [PATCH] drm/xe: Fix static analysis tool reported errors
> 
> Add a NULL pointer check.
> 
> v2: Release resources before returning error. (Riana).
> 
> Fixes: 09d88e3beb64 ("drm/xe/pm: Init pcode and restore vram on power
> lost")
> Signed-off-by: Karthik Poosa <karthik.poosa at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c index
> cc650a92c2fc..46abf63bc37b 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -383,6 +383,12 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>  	 * really lost power. Detecting primary Gt power is sufficient.
>  	 */
>  	gt = xe_device_get_gt(xe, 0);
> +	if (!gt) {
Use xe_warn_on() here.
Thanks,
Anshuman
> +		drm_err(&xe->drm, "xe_gt pointer NULL in xe_device\n");
> +		err = -ENXIO;
> +		goto out;
> +	}
> +
>  	xe->d3cold.power_lost = xe_guc_in_reset(&gt->uc.guc);
> 
>  	if (xe->d3cold.allowed && xe->d3cold.power_lost) {
> --
> 2.25.1