[PATCH v4 08/30] drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue

Zeng, Oak oak.zeng at intel.com
Mon Mar 25 16:05:11 UTC 2024


This patch lgtm. Reviewed-by: Oak Zeng <oak.zeng at intel.com>

Oak

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew
> Brost
> Sent: Friday, March 8, 2024 12:08 AM
> To: intel-xe at lists.freedesktop.org
> Cc: Brost, Matthew <matthew.brost at intel.com>
> Subject: [PATCH v4 08/30] drm/xe:
> s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue
> 
> xe_engine is now xe_exec_queue, adjust this function's name to reflect.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_pagefault.c | 2 +-
>  drivers/gpu/drm/xe/xe_migrate.c      | 8 ++++----
>  drivers/gpu/drm/xe/xe_migrate.h      | 3 ++-
>  3 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c
> b/drivers/gpu/drm/xe/xe_gt_pagefault.c
> index 3c7d6e4e3917..878e234166aa 100644
> --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
> +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
> @@ -210,7 +210,7 @@ static int handle_pagefault(struct xe_gt *gt, struct
> pagefault *pf)
>  	trace_xe_vma_pf_bind(vma);
>  	xe_vm_populate_dummy_rebind(vm, vma);
>  	vm->dummy_ops.op.tile_mask = BIT(tile->id);
> -	vm->dummy_ops.op.q = xe_tile_migrate_engine(tile);
> +	vm->dummy_ops.op.q = xe_tile_migrate_exec_queue(tile);
>  	fence = xe_vm_ops_execute(vm, &vm->dummy_ops.vops);
>  	if (IS_ERR(fence)) {
>  		ret = PTR_ERR(fence);
> diff --git a/drivers/gpu/drm/xe/xe_migrate.c
> b/drivers/gpu/drm/xe/xe_migrate.c
> index ee1bb938c493..3fd76f912fda 100644
> --- a/drivers/gpu/drm/xe/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/xe_migrate.c
> @@ -84,15 +84,15 @@ struct xe_migrate {
>  #define MAX_PTE_PER_SDI 0x1FE
> 
>  /**
> - * xe_tile_migrate_engine() - Get this tile's migrate engine.
> + * xe_tile_migrate_exec_queue() - Get this tile's migrate exec queue.
>   * @tile: The tile.
>   *
> - * Returns the default migrate engine of this tile.
> + * Returns the default migrate exec queue of this tile.
>   * TODO: Perhaps this function is slightly misplaced, and even unneeded?
>   *
> - * Return: The default migrate engine
> + * Return: The default migrate exec queue
>   */
> -struct xe_exec_queue *xe_tile_migrate_engine(struct xe_tile *tile)
> +struct xe_exec_queue *xe_tile_migrate_exec_queue(struct xe_tile *tile)
>  {
>  	return tile->migrate->q;
>  }
> diff --git a/drivers/gpu/drm/xe/xe_migrate.h
> b/drivers/gpu/drm/xe/xe_migrate.h
> index 951f19318ea4..9935ce336bae 100644
> --- a/drivers/gpu/drm/xe/xe_migrate.h
> +++ b/drivers/gpu/drm/xe/xe_migrate.h
> @@ -106,5 +106,6 @@ xe_migrate_update_pgtables(struct xe_migrate *m,
> 
>  void xe_migrate_wait(struct xe_migrate *m);
> 
> -struct xe_exec_queue *xe_tile_migrate_engine(struct xe_tile *tile);
> +struct xe_exec_queue *xe_tile_migrate_exec_queue(struct xe_tile *tile);
> +
>  #endif
> --
> 2.34.1



More information about the Intel-xe mailing list