✗ CI.checkpatch: warning for series starting with [1/3] drm/xe: Store xe_he_engine in xe_hw_engine_snapshot

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 25 19:25:33 UTC 2024


== Series Details ==

Series: series starting with [1/3] drm/xe: Store xe_he_engine in xe_hw_engine_snapshot
URL   : https://patchwork.freedesktop.org/series/131599/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5f4a2492025d7972b1e29a22594b5a770e996bcd
Author: José Roberto de Souza <jose.souza at intel.com>
Date:   Mon Mar 25 12:06:43 2024 -0700

    drm/xe: Add INSTDONE registers to devcoredump
    
    This registers contains important information that can help with debug
    of GPU hangs.
    
    While at it also fixing the double line jump at the end of engine
    registers for CCS engines.
    
    v2:
    - print other INSTDONE registers
    
    v3:
    - add for_each_geometry/compute_dss()
    
    v4:
    - print one slice_common_instdone per glice in DG2+
    
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Matt Roper <matthew.d.roper at intel.com>
    Cc: Zhanjun Dong <zhanjun.dong at intel.com>
    Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch 17ec6923f2c5bb23280b274d6359a44a6982982e drm-intel
c2cc1785efff drm/xe: Store xe_he_engine in xe_hw_engine_snapshot
25a7de1dfe54 drm/xe: Add helpers to loop over geometry and compute DSS
-:36: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#36: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:51:
+#define for_each_geometry_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_geometry_dss(gt, dss))

-:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss' - possible side-effects?
#36: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:51:
+#define for_each_geometry_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_geometry_dss(gt, dss))

-:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#36: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:51:
+#define for_each_geometry_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_geometry_dss(gt, dss))

-:48: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#48: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:63:
+#define for_each_compute_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_compute_dss(gt, dss))

-:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dss' - possible side-effects?
#48: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:63:
+#define for_each_compute_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_compute_dss(gt, dss))

-:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#48: FILE: drivers/gpu/drm/xe/xe_gt_mcr.h:63:
+#define for_each_compute_dss(dss, gt, group, instance) \
+		for_each_dss_steering(dss, gt, group, instance) \
+			if (xe_gt_has_compute_dss(gt, dss))

total: 2 errors, 0 warnings, 4 checks, 55 lines checked
5f4a2492025d drm/xe: Add INSTDONE registers to devcoredump




More information about the Intel-xe mailing list