[PATCH] drm/i915: use fine grained -Woverride-init disable

[Lucas De Marchi]

On Thu, Mar 28, 2024 at 12:24:55PM +0200, Jani Nikula wrote:
>Use localized __diag_push(), __diag_ignore_all() with rationale, and
>__diag_pop() for specific initializations instead of blanket disabling
>of -Woverride-init across several files.
>
>Note that we've tried this before with commit 88e9664434c9 ("drm/i915:
>use localized __diag_ignore_all() instead of per file") and reverted in
>commit 290d16104575 ("Revert "drm/i915: use localized
>__diag_ignore_all() instead of per file""). The issue turned out to be
>in __diag_ignore_all() and it was fixed by commit 689b097a06ba
>("compiler-gcc: Suppress -Wmissing-prototypes warning for all supported
>GCC"). So we should be able to pull this off now.
>
>Cc: "Arnd Bergmann" <arnd at arndb.de>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: Jani Nikula <jani.nikula at intel.com>

great! I had a vague memory of us using these localized warning-suppress
rather than doing it on the entire files.

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi