[PATCH] drm/xe/uapi: Define topology types as indexes rather than masks

[Lucas De Marchi]

On Thu, Mar 28, 2024 at 02:02:43PM +0000, Francois Dugast wrote:
>The topology type is an index (not a mask) so define the values
>like other indexes instead of using powers of 2. This is also
>to make clear that the next type can use value 3. This commit
>does not change the existing values so it does not break
>compatibility.
>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Suggested-by: Matt Roper <matthew.d.roper at intel.com>
>Signed-off-by: Francois Dugast <francois.dugast at intel.com>
>Link: https://lore.kernel.org/intel-xe/20240327232317.GI718896@mdroper-desk1.amr.corp.intel.com/

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>---
> include/uapi/drm/xe_drm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
>index 808ad1c308ec..95a8ecca21f4 100644
>--- a/include/uapi/drm/xe_drm.h
>+++ b/include/uapi/drm/xe_drm.h
>@@ -518,9 +518,9 @@ struct drm_xe_query_topology_mask {
> 	/** @gt_id: GT ID the mask is associated with */
> 	__u16 gt_id;
>
>-#define DRM_XE_TOPO_DSS_GEOMETRY	(1 << 0)
>-#define DRM_XE_TOPO_DSS_COMPUTE		(1 << 1)
>-#define DRM_XE_TOPO_EU_PER_DSS		(1 << 2)
>+#define DRM_XE_TOPO_DSS_GEOMETRY	1
>+#define DRM_XE_TOPO_DSS_COMPUTE		2
>+#define DRM_XE_TOPO_EU_PER_DSS		4
> 	/** @type: type of mask */
> 	__u16 type;
>
>-- 
>2.34.1
>