[PATCH 7/8] drm/xe/device: move flr to devm

Andrzej Hajda andrzej.hajda at intel.com
Mon May 6 09:12:53 UTC 2024


On 29.04.2024 14:14, Matthew Auld wrote:
> Should be called when driver is removed, not when this particular driver
> instance is destroyed.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>

Regards
Andrzej
> ---
>   drivers/gpu/drm/xe/xe_device.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index b61f8356e23e..ba917e383f8f 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -387,7 +387,7 @@ static void xe_driver_flr(struct xe_device *xe)
>   	xe_mmio_write32(gt, GU_DEBUG, DRIVERFLR_STATUS);
>   }
>   
> -static void xe_driver_flr_fini(struct drm_device *drm, void *arg)
> +static void xe_driver_flr_fini(void *arg)
>   {
>   	struct xe_device *xe = arg;
>   
> @@ -589,7 +589,7 @@ int xe_device_probe(struct xe_device *xe)
>   	err = xe_devcoredump_init(xe);
>   	if (err)
>   		return err;
> -	err = drmm_add_action_or_reset(&xe->drm, xe_driver_flr_fini, xe);
> +	err = devm_add_action_or_reset(xe->drm.dev, xe_driver_flr_fini, xe);
>   	if (err)
>   		return err;
>   



More information about the Intel-xe mailing list