[PATCH 2/7] drm/xe: Fix xe_pm_runtime_get_if_in_use documentation

Thomas Hellström thomas.hellstrom at linux.intel.com
Mon May 6 11:49:46 UTC 2024


On Fri, 2024-05-03 at 15:13 -0400, Rodrigo Vivi wrote:
> Let's be clear on what it is actually doing and align with
> xe_pm_runtime_get_if_active doc style.
> 
> Cc: Francois Dugast <francois.dugast at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index eca977d1e1cb..c3adcbaba223 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -514,10 +514,11 @@ bool xe_pm_runtime_get_if_active(struct
> xe_device *xe)
>  }
>  
>  /**
> - * xe_pm_runtime_get_if_in_use - Get a runtime_pm reference and
> resume if needed
> + * xe_pm_runtime_get_if_in_use - Get a new reference if device is
> active with previous ref taken
>   * @xe: xe device instance
>   *
> - * Returns: True if device is awake and the reference was taken,
> false otherwise.
> + * Returns: True if device is awake, a previous reference had been
> already taken,
Same here.

Reviewed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>


> + * and a new reference was now taken, false otherwise.
>   */
>  bool xe_pm_runtime_get_if_in_use(struct xe_device *xe)
>  {



More information about the Intel-xe mailing list