✗ CI.checkpatch: warning for drm/xe: Nuke xe's copy of intel_fbdev_fb.h
Patchwork
patchwork at emeril.freedesktop.org
Mon May 6 20:54:40 UTC 2024
== Series Details ==
Series: drm/xe: Nuke xe's copy of intel_fbdev_fb.h
URL : https://patchwork.freedesktop.org/series/133247/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e7224a08febb4c7b19a7032b7d78848221ac91bb
Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
Date: Mon May 6 21:33:31 2024 +0300
drm/xe: Nuke xe's copy of intel_fbdev_fb.h
For some reason xe and i915 each have an identical (fortunately)
copy of intel_fbdev_fb.h. The xe copy actually only gets included
by xe's intel_fbdev_fb.c, and the i915 copy by everyone else,
include intel_fbdev.c which is the actual caller of the
functions declared in the header.
This means the xe and i915 headers are free to define/declare
completely incompatible things and the build would still succeed
as long as the symbol names match.
That is not a good thing, so let's nuke xe's copy of the header
so that everyone will use the same header, and be forced to
agree on the same API/ABI.
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
+ /mt/dim checkpatch 83e0d2a2621c7550c198b8936f4680b24f24a698 drm-intel
e7224a08febb drm/xe: Nuke xe's copy of intel_fbdev_fb.h
-:26: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#26:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 0 lines checked
More information about the Intel-xe
mailing list