[PATCH v2 4/4] drm/xe/xe2: Enable Indirect Ring State support for Xe2

Matt Roper matthew.d.roper at intel.com
Tue May 7 22:20:06 UTC 2024


On Mon, May 06, 2024 at 10:11:05AM -0700, Niranjana Vishwanathapura wrote:
> Indirect Ring State is the recommended mode for Xe2 platforms,
> enable it by default.
> 
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 8f3e4c563105..c8512571fca8 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -166,6 +166,7 @@ static const struct xe_graphics_desc graphics_xelpg = {
>  	.has_asid = 1, \
>  	.has_atomic_enable_pte_bit = 1, \
>  	.has_flat_ccs = 1, \
> +	.has_indirect_ring_state = true, \

Nitpick, but I'd use "= 1" instead of "= true" here for consistency with
the other fields and since this is a 1-bit bitfield entry rather than a
standalone bool.  Aside from that,

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

>  	.has_range_tlb_invalidation = 1, \
>  	.has_usm = 1, \
>  	.va_bits = 48, \
> -- 
> 2.43.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list