✗ CI.checkpatch: warning for Cursor Fault Fix (rev2)

[Patchwork]

== Series Details ==

Series: Cursor Fault Fix (rev2)
URL   : https://patchwork.freedesktop.org/series/133310/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 71b3ba2b2fd15cea2e2f986ec1f43a8a192f2907
Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Date:   Wed May 8 13:09:04 2024 +0530

    drm/i915: Use the same vblank worker for atomic unpin
    
    In case of legacy cursor update, the cursor VMA needs to be unpinned
    only after vblank. This exceeds the lifetime of the whole atomic commit.
    
    Any trick I attempted to keep the atomic commit alive didn't work, as
    drm_atomic_helper_setup_commit() force throttles on any old commit that
    wasn't cleaned up.
    
    The only option remaining is to remove the plane from the atomic commit,
    and use the same path as the legacy cursor update to clean the state
    after vblank.
    
    Changes since previous version:
    - Call the memset for plane state immediately when scheduling vblank,
      this prevents a use-after-free in cursor cleanup.
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
+ /mt/dim checkpatch 9cc0aaf4a2ce2abb40e637ec41c9f12aa83f9417 drm-intel
af6aad48edc3 drm: Add drm_vblank_work_flush_all().
-:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active without comment
#33: FILE: drivers/gpu/drm/drm_vblank_work.c:249:
+			    !waitqueue_active(&vblank->work_wait_queue),

total: 0 errors, 1 warnings, 0 checks, 41 lines checked
07ed797d0206 drm: Add helper to check if there are pending vblank work
aee908cdeedf drm/i915: Use vblank worker to unpin old legacy cursor fb safely
-:103: ERROR:SPACING: space required before the open parenthesis '('
#103: FILE: drivers/gpu/drm/i915/display/intel_display.c:6928:
+		if(drm_vblank_has_pending_work(&crtc->base)) {

total: 1 errors, 0 warnings, 0 checks, 71 lines checked
71b3ba2b2fd1 drm/i915: Use the same vblank worker for atomic unpin
-:107: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#107: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:641:
+							 drm_crtc_accurate_vblank_count(&crtc->base) + 1,

-:110: WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#110: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:644:
+				/* Remove plane from atomic state, cleanup/free is done from vblank worker. */

total: 0 errors, 2 warnings, 0 checks, 98 lines checked