[PATCH 1/2] drm/xe: Change pcode timeout to 50msec while polling again

Lucas De Marchi lucas.demarchi at intel.com
Wed May 8 17:20:50 UTC 2024


On Wed, May 08, 2024 at 08:52:15PM GMT, Himal Prasad Ghimiray wrote:
>Polling is initially attempted with timeout_base_ms enabled for
>preemption, and if it exceeds this timeframe, another attempt is made
>without preemption, allowing an additional 50 ms before timing out.
>
>v2
>- Rebase
>
>v3
>- Move warnings to separate patch (Lucas)
>

Fixes: 7dc9b92dcfef ("drm/xe: Remove i915_utils dependency from xe_pcode.") 
Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
>---
> drivers/gpu/drm/xe/xe_pcode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
>index c010ef16fbf5..a5e7da8cf944 100644
>--- a/drivers/gpu/drm/xe/xe_pcode.c
>+++ b/drivers/gpu/drm/xe/xe_pcode.c
>@@ -191,7 +191,7 @@ int xe_pcode_request(struct xe_gt *gt, u32 mbox, u32 request,
> 	drm_WARN_ON_ONCE(&gt_to_xe(gt)->drm, timeout_base_ms > 1);
> 	preempt_disable();
> 	ret = pcode_try_request(gt, mbox, request, reply_mask, reply, &status,
>-				true, timeout_base_ms * 1000, true);
>+				true, 50 * 1000, true);
> 	preempt_enable();
>
> out:
>-- 
>2.25.1
>


More information about the Intel-xe mailing list