[PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

[Lucas De Marchi]

On Wed, May 08, 2024 at 10:52:54PM GMT, Ville Syrjälä wrote:
>On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote:
>> On Mon, 06 May 2024, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> >
>> > For some reason xe and i915 each have an identical (fortunately)
>> > copy of intel_fbdev_fb.h. The xe copy actually only gets included
>> > by xe's intel_fbdev_fb.c, and the i915 copy by everyone else,
>> > include intel_fbdev.c which is the actual caller of the
>> > functions declared in the header.
>> >
>> > This means the xe and i915 headers are free to define/declare
>> > completely incompatible things and the build would still succeed
>> > as long as the symbol names match.
>> >
>> > That is not a good thing, so let's nuke xe's copy of the header
>> > so that everyone will use the same header, and be forced to
>> > agree on the same API/ABI.
>> >
>> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>
>> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
>
>Thanks.
>
>I was going to push this to drm-xe-next, but I should actually
>push it to drm-intel-next since I'll be massaging this stuff
>there.
>
>xe maintainers, ack for merging via drm-intel-next?


Acked-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi