[PATCH v8 3/6] drm/xe/guc: Add capture size check in GuC log buffer

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Wed May 8 22:57:44 UTC 2024


On Mon, 2024-05-06 at 18:47 -0700, Zhanjun Dong wrote:
> The capture-nodes is included in GuC log buffer, add the size check
> for capture region in the whole GuC log buffer.
> Check the worst size of register capture aginst error capture region
> size.
> 
alan:snip

> +
> +#define GUC_LOG_DEFAULT_CRASH_BUFFER_SIZE      CRASH_BUFFER_SIZE
> +#define GUC_LOG_DEFAULT_DEBUG_BUFFER_SIZE      DEBUG_BUFFER_SIZE
> +#define GUC_LOG_DEFAULT_CAPTURE_BUFFER_SIZE    CAPTURE_BUFFER_SIZE
> +

nit: actually not sure why we need the define on the left, since the
usage could just use the ones its sourced from on the right.

alan: as per offline conversation, we beilieve the default size needs t
to larger to accomodate back to back worst case capture sizes.
So as per offline, we need to increase that to at least 32K? (or 128K
with spare)


More information about the Intel-xe mailing list