[PATCH] drm/xe: Move xe_gpu_commands.h file to instructions/

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Thu May 9 04:37:07 UTC 2024


On 08-05-2024 23:18, Michal Wajdeczko wrote:
> All other files with commands definitions are in instructions/
> folder. Move xe_gpu_commands.h also there.


LGTM

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>

Thanks.


>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> ---
>   drivers/gpu/drm/xe/{regs => instructions}/xe_gpu_commands.h | 0
>   drivers/gpu/drm/xe/xe_bb.c                                  | 1 -
>   drivers/gpu/drm/xe/xe_device.c                              | 2 +-
>   drivers/gpu/drm/xe/xe_execlist.c                            | 1 -
>   drivers/gpu/drm/xe/xe_lrc.c                                 | 1 -
>   drivers/gpu/drm/xe/xe_migrate.c                             | 2 +-
>   drivers/gpu/drm/xe/xe_ring_ops.c                            | 2 +-
>   7 files changed, 3 insertions(+), 6 deletions(-)
>   rename drivers/gpu/drm/xe/{regs => instructions}/xe_gpu_commands.h (100%)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_gpu_commands.h b/drivers/gpu/drm/xe/instructions/xe_gpu_commands.h
> similarity index 100%
> rename from drivers/gpu/drm/xe/regs/xe_gpu_commands.h
> rename to drivers/gpu/drm/xe/instructions/xe_gpu_commands.h
> diff --git a/drivers/gpu/drm/xe/xe_bb.c b/drivers/gpu/drm/xe/xe_bb.c
> index 37e056fde95d..a13e0b3a169e 100644
> --- a/drivers/gpu/drm/xe/xe_bb.c
> +++ b/drivers/gpu/drm/xe/xe_bb.c
> @@ -6,7 +6,6 @@
>   #include "xe_bb.h"
>   
>   #include "instructions/xe_mi_commands.h"
> -#include "regs/xe_gpu_commands.h"
>   #include "xe_assert.h"
>   #include "xe_device.h"
>   #include "xe_exec_queue_types.h"
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index b63d98872a41..f89c781986a5 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -17,7 +17,7 @@
>   #include <drm/xe_drm.h>
>   
>   #include "display/xe_display.h"
> -#include "regs/xe_gpu_commands.h"
> +#include "instructions/xe_gpu_commands.h"
>   #include "regs/xe_gt_regs.h"
>   #include "regs/xe_regs.h"
>   #include "xe_bo.h"
> diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c
> index dece2785933c..e9dee1e14fef 100644
> --- a/drivers/gpu/drm/xe/xe_execlist.c
> +++ b/drivers/gpu/drm/xe/xe_execlist.c
> @@ -9,7 +9,6 @@
>   
>   #include "instructions/xe_mi_commands.h"
>   #include "regs/xe_engine_regs.h"
> -#include "regs/xe_gpu_commands.h"
>   #include "regs/xe_gt_regs.h"
>   #include "regs/xe_lrc_layout.h"
>   #include "xe_assert.h"
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index 2066d34ddf0b..a0cdd6977ebe 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -11,7 +11,6 @@
>   #include "instructions/xe_gfxpipe_commands.h"
>   #include "instructions/xe_gfx_state_commands.h"
>   #include "regs/xe_engine_regs.h"
> -#include "regs/xe_gpu_commands.h"
>   #include "regs/xe_lrc_layout.h"
>   #include "xe_bb.h"
>   #include "xe_bo.h"
> diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
> index 9f6e9b7f11c8..36db5ed1a572 100644
> --- a/drivers/gpu/drm/xe/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/xe_migrate.c
> @@ -14,8 +14,8 @@
>   
>   #include <generated/xe_wa_oob.h>
>   
> +#include "instructions/xe_gpu_commands.h"
>   #include "instructions/xe_mi_commands.h"
> -#include "regs/xe_gpu_commands.h"
>   #include "regs/xe_gtt_defs.h"
>   #include "tests/xe_test.h"
>   #include "xe_assert.h"
> diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
> index d42b3f33bd7a..a3ca718456f6 100644
> --- a/drivers/gpu/drm/xe/xe_ring_ops.c
> +++ b/drivers/gpu/drm/xe/xe_ring_ops.c
> @@ -7,9 +7,9 @@
>   
>   #include <generated/xe_wa_oob.h>
>   
> +#include "instructions/xe_gpu_commands.h"
>   #include "instructions/xe_mi_commands.h"
>   #include "regs/xe_engine_regs.h"
> -#include "regs/xe_gpu_commands.h"
>   #include "regs/xe_gt_regs.h"
>   #include "regs/xe_lrc_layout.h"
>   #include "xe_exec_queue_types.h"


More information about the Intel-xe mailing list