[PATCH 7/7] drm/xe: Enable D3Cold on 'low' VRAM utilization

[Gupta, Anshuman]

> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.vivi at intel.com>
> Sent: Saturday, May 4, 2024 12:43 AM
> To: intel-xe at lists.freedesktop.org
> Cc: De Marchi, Lucas <lucas.demarchi at intel.com>; Brost, Matthew
> <matthew.brost at intel.com>; Dugast, Francois <francois.dugast at intel.com>;
> thomas.hellstrom at linux.intel.com; Auld, Matthew
> <matthew.auld at intel.com>; Gupta, Anshuman
> <anshuman.gupta at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>
> Subject: [PATCH 7/7] drm/xe: Enable D3Cold on 'low' VRAM utilization
> 
> Now that we eliminated all the mem_access get/put with its locking issues
> from the inner calls of migration, we can allow D3Cold.
> 
> Enable it when VRAM utilization is lower then 300Mb. On higher utilization
> we only allow D3hot so we don't increase so much the latency on runtime
> resume due to the memory restoration.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Looks good to me.
Reviewed-by: Anshuman Gupta <anshuman.gupta at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pm.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.h b/drivers/gpu/drm/xe/xe_pm.h
> index f694005db278..104a21ae6dfd 100644
> --- a/drivers/gpu/drm/xe/xe_pm.h
> +++ b/drivers/gpu/drm/xe/xe_pm.h
> @@ -8,12 +8,7 @@
> 
>  #include <linux/pm_runtime.h>
> 
> -/*
> - * TODO: Threshold = 0 will block D3Cold.
> - *       Before we can move this to a higher value (like 300), we need to:
> - *           1. rewrite the VRAM save / restore to avoid buffer object locks
> - */
> -#define DEFAULT_VRAM_THRESHOLD 0 /* in MB */
> +#define DEFAULT_VRAM_THRESHOLD 300 /* in MB */
> 
>  struct xe_device;
> 
> --
> 2.44.0