✗ CI.checkpatch: warning for drm/xe: add mmio debugfs file & restore xe_mmio_ioctl as its ioctl handler
Patchwork
patchwork at emeril.freedesktop.org
Mon May 13 07:20:55 UTC 2024
== Series Details ==
Series: drm/xe: add mmio debugfs file & restore xe_mmio_ioctl as its ioctl handler
URL : https://patchwork.freedesktop.org/series/133505/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
57b97a66dd129aea93991dc66cd10477f7a05cf8
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e4328da38576b13d15e0a0df3801d5ce6deb8236
Author: Koby Elbaz <kelbaz at habana.ai>
Date: Sun May 12 15:53:18 2024 +0300
drm/xe: add mmio debugfs file & restore xe_mmio_ioctl as its ioctl handler
The drm mmio ioctl handler (xe_mmio_ioctl) wasn't needed anymore,
and therefore, recently removed.
Nevertheless, it is now restored for debugging purposes as an
ioctl handler for a newly added 'mmio' debugfs file.
Notes:
1. The non-admin user's limited mmio access (aka, whitelist),
was removed being irrelevant anymore, now that a user using debugfs
must anyway have root permissions to use it.
2. To support multi-tile access, the tile index is now dynamic and
will be retrieved from the given mmio address itself.
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Ofir Bitton <obitton at habana.ai>
Cc: José Roberto de Souza <jose.souza at intel.com>
Signed-off-by: Koby Elbaz <kelbaz at habana.ai>
+ /mt/dim checkpatch b5f09c51c3bb7cf14cac3e484880efdb405c098c drm-intel
e4328da38576 drm/xe: add mmio debugfs file & restore xe_mmio_ioctl as its ioctl handler
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:67: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mmio_addr >= tile_mmio_base_addr'
#67: FILE: drivers/gpu/drm/xe/xe_debugfs.c:133:
+ if ((mmio_addr >= tile_mmio_base_addr) &&
+ (mmio_addr < (tile_mmio_base_addr + SZ_4M))) {
-:68: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#68: FILE: drivers/gpu/drm/xe/xe_debugfs.c:134:
+ if ((mmio_addr >= tile_mmio_base_addr) &&
+ (mmio_addr < (tile_mmio_base_addr + SZ_4M))) {
-:238: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#238:
new file mode 100644
total: 0 errors, 1 warnings, 2 checks, 243 lines checked
More information about the Intel-xe
mailing list