✗ CI.checkpatch: warning for xe bo shrinker and exhaustive eviction (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Wed May 15 14:54:15 UTC 2024
== Series Details ==
Series: xe bo shrinker and exhaustive eviction (rev2)
URL : https://patchwork.freedesktop.org/series/133643/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
57b97a66dd129aea93991dc66cd10477f7a05cf8
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 816bd048bcc3def8f7f86e6e511dd9b73267d7ae
Author: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Date: Wed May 15 10:14:49 2024 +0200
drm/xe: Initial support for drm exec locking during validate.
Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
+ /mt/dim checkpatch d98c9eae84056cb2d86293c145234017681f09f4 drm-intel
b53fc38fd1a3 drm/ttm: Allow TTM LRU list nodes of different types
b976b7e553b8 drm/ttm: Slightly clean up LRU list iteration
bd87efb68891 drm/ttm: Use LRU hitches
6f6a0f5276ac drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves
785e3b5fe252 drm/exec: Rework contended locking
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:436: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'exec' - possible side-effects?
#436: FILE: include/drm/drm_exec.h:122:
+#define drm_exec_retry_on_contention(exec, _ret) \
+ ({ \
+ int __ret = (_ret); \
+ \
+ if (unlikely(drm_exec_is_contended(exec))) { \
+ WARN_ON(__ret != -EDEADLK); \
+ __ret = drm_exec_handle_contended(exec); \
+ if (!__ret) \
+ goto *__drm_exec_retry_ptr; \
+ } \
+ __ret; \
+ })
-:436: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#436: FILE: include/drm/drm_exec.h:122:
+#define drm_exec_retry_on_contention(exec, _ret) \
+ ({ \
+ int __ret = (_ret); \
+ \
+ if (unlikely(drm_exec_is_contended(exec))) { \
+ WARN_ON(__ret != -EDEADLK); \
+ __ret = drm_exec_handle_contended(exec); \
+ if (!__ret) \
+ goto *__drm_exec_retry_ptr; \
+ } \
+ __ret; \
+ })
total: 0 errors, 2 warnings, 1 checks, 356 lines checked
40dba2cbbaad drm/ttm: Provide a generic LRU walker helper
-:128: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#128: FILE: drivers/gpu/drm/ttm/ttm_bo_util.c:867:
+long ttm_lru_walk_for_evict(struct ttm_lru_walk *walk, struct ttm_device *bdev,
+ struct ttm_resource_manager *man, long target)
-:141: ERROR:TRAILING_WHITESPACE: trailing whitespace
#141: FILE: drivers/gpu/drm/ttm/ttm_bo_util.c:880:
+^I^I$
total: 1 errors, 0 warnings, 1 checks, 203 lines checked
8a9857d1267d drm/ttm: Use restartable LRU and sleeping locks for swapping.
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:21: CHECK:LINE_SPACING: Please don't use multiple blank lines
#21: FILE: drivers/gpu/drm/ttm/ttm_bo.c:1121:
+
-:148: ERROR:TRAILING_WHITESPACE: trailing whitespace
#148: FILE: drivers/gpu/drm/ttm/ttm_bo.c:1232:
+^I$
total: 1 errors, 1 warnings, 1 checks, 187 lines checked
c115d4a9c336 drm/ttm: sleeping evict lock.
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:142: ERROR:TRAILING_WHITESPACE: trailing whitespace
#142: FILE: drivers/gpu/drm/ttm/ttm_bo.c:441:
+^I$
-:168: ERROR:TRAILING_WHITESPACE: trailing whitespace
#168: FILE: drivers/gpu/drm/ttm/ttm_bo.c:460:
+^I} else {^I$
-:177: ERROR:TRAILING_WHITESPACE: trailing whitespace
#177: FILE: drivers/gpu/drm/ttm/ttm_bo.c:468:
+^I$
-:183: ERROR:TRAILING_WHITESPACE: trailing whitespace
#183: FILE: drivers/gpu/drm/ttm/ttm_bo.c:474:
+^I^I$
-:225: ERROR:TRAILING_WHITESPACE: trailing whitespace
#225: FILE: drivers/gpu/drm/ttm/ttm_bo.c:496:
+^I} else {^I$
-:244: ERROR:TRAILING_WHITESPACE: trailing whitespace
#244: FILE: drivers/gpu/drm/ttm/ttm_bo.c:507:
+^Iif (lret == 0) $
-:251: ERROR:TRAILING_WHITESPACE: trailing whitespace
#251: FILE: drivers/gpu/drm/ttm/ttm_bo.c:514:
+^I$
-:384: ERROR:TRAILING_WHITESPACE: trailing whitespace
#384: FILE: drivers/gpu/drm/ttm/ttm_bo.c:683:
+^I^I^I^Ireturn ret;^I^I$
-:461: ERROR:TRAILING_WHITESPACE: trailing whitespace
#461: FILE: drivers/gpu/drm/ttm/ttm_resource.c:516:
+^I$
total: 9 errors, 1 warnings, 0 checks, 448 lines checked
25ab02e4b174 drm/ttm: Add a virtual base class for graphics memory backup
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:41: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 281 lines checked
0ba8a60aad0b drm/ttm/pool: Provide a helper to shrink pages.
3e030e48aa27 drm/ttm: Use fault-injection to test error paths
-:27: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol
#27: FILE: drivers/gpu/drm/Kconfig:261:
+config DRM_TTM_BACKUP_FAULT_INJECT
+ bool "Enable fault injection during TTM backup"
+ depends on DRM_TTM
+ default n
+ help
+ Inject recoverable failures during TTM backup and recovery of
+ backed-up objects. For DRM driver developers only.
+
+ If in doubt, choose N.
+
total: 0 errors, 1 warnings, 0 checks, 51 lines checked
ea19135e331f drm/ttm, drm/xe: Add a shrinker for xe bos
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:616: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#616:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 781 lines checked
1b8d3569e682 dma-buf/dma-resv: Introduce dma_resv_trylock_ctx()
-:24: CHECK:LINE_SPACING: Please don't use multiple blank lines
#24: FILE: include/linux/dma-resv.h:408:
+
total: 0 errors, 0 warnings, 1 checks, 37 lines checked
23caf5ab23b0 drm/exec: drm_exec_trylock()
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 51 lines checked
f13a9f0b8aba drm/exec: Add a snapshot capability.
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:52: ERROR:TRAILING_WHITESPACE: trailing whitespace
#52: FILE: drivers/gpu/drm/drm_exec.c:403:
+^I$
-:67: ERROR:TRAILING_WHITESPACE: trailing whitespace
#67: FILE: drivers/gpu/drm/drm_exec.c:418:
+^Iexec->snap = snap;^I$
-:103: CHECK:LINE_SPACING: Please don't use multiple blank lines
#103: FILE: include/drm/drm_exec.h:153:
+
total: 2 errors, 1 warnings, 1 checks, 91 lines checked
5b400f926ea2 drm/exec: Introduce an evict mode
-:72: CHECK:SPACING: No space is necessary after a cast
#72: FILE: drivers/gpu/drm/drm_exec.c:150:
+ return (unsigned long) resv / __alignof__(typeof(*resv));
-:107: CHECK:SPACING: No space is necessary after a cast
#107: FILE: drivers/gpu/drm/drm_exec.c:197:
+ (void) xa_store(&exec->resv_set, drm_exec_resv_to_key(obj->resv),
total: 0 errors, 0 warnings, 2 checks, 177 lines checked
607317448e8e drm/ttm: Support drm_exec locking for eviction and swapping
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:51: ERROR:TRAILING_WHITESPACE: trailing whitespace
#51: FILE: drivers/gpu/drm/ttm/ttm_bo.c:779:
+ $
-:51: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#51: FILE: drivers/gpu/drm/ttm/ttm_bo.c:779:
+ $
-:186: ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: drivers/gpu/drm/ttm/ttm_bo_util.c:926:
+^I^I^I lret = ttm_lru_walk_execlock(walk, bo);$
-:236: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 3 errors, 2 warnings, 0 checks, 202 lines checked
9a76699c1e77 drm/ttm: Convert ttm vm to using drm_exec.
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:266: ERROR:TRAILING_WHITESPACE: trailing whitespace
#266: FILE: drivers/gpu/drm/ttm/ttm_bo_vm.c:354:
+^I$
total: 1 errors, 1 warnings, 0 checks, 302 lines checked
8109386bdd69 drm/xe: Use drm_exec for fault locking
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
eec6f163cfa6 drm/ttm: Use drm_exec_trylock for bo initialization
816bd048bcc3 drm/xe: Initial support for drm exec locking during validate.
-:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 142 lines checked
More information about the Intel-xe
mailing list