[PATCH] drm/xe: Properly handle alloc_guc_id() failure

Matthew Brost matthew.brost at intel.com
Tue May 21 20:06:39 UTC 2024


On Tue, May 21, 2024 at 12:37:39PM -0700, Niranjana Vishwanathapura wrote:
> Release the submission_state lock if alloc_guc_id() fails.
> 

Fixes tag and CC stable kernel?

With new tags:
Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index ad2b8067d071..c0b901c5565b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
>  	return 0;
>  
>  err_entity:
> +	mutex_unlock(&guc->submission_state.lock);
>  	xe_sched_entity_fini(&ge->entity);
>  err_sched:
>  	xe_sched_fini(&ge->sched);
> -- 
> 2.43.0
> 


More information about the Intel-xe mailing list