✓ CI.checkpatch: success for series starting with [1/2] drm/xe: Use run_ticks instead of runtime for client stats
Patchwork
patchwork at emeril.freedesktop.org
Fri May 24 21:25:25 UTC 2024
== Series Details ==
Series: series starting with [1/2] drm/xe: Use run_ticks instead of runtime for client stats
URL : https://patchwork.freedesktop.org/series/134033/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 02d3c09c62628d5a7c8fdff7c6903f09dc860617
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Date: Fri May 24 14:09:49 2024 -0700
drm/xe: Do not access xe file when updating exec queue run_ticks
The current code is running into a use after free case where xe file is
closed before the exec queue run_ticks can be updated. This is occurring
in the xe_file_close path. To fix that, do not access xe file when
updating the exec queue run_ticks. Instead store the exec queue run_ticks
locally in the exec queue object and accumulate it when the user dumps
the drm client stats. We know that the xe file is valid when user is
dumping the run_ticks for the drm client, so this effectively
removes the dependency on xe file object in
xe_exec_queue_update_run_ticks().
v2:
- Fix the accumulation of q->run_ticks delta into xe file run_ticks
- s/runtime/run_ticks/ (Rodrigo)
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1908
Fixes: 6109f24f87d7 ("drm/xe: Add helper to accumulate exec queue runtime")
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 573842e9ab57ccd8d6bb68ad55ed2e012e3d5d2f drm-intel
6d1e61414020 drm/xe: Use run_ticks instead of runtime for client stats
02d3c09c6262 drm/xe: Do not access xe file when updating exec queue run_ticks
More information about the Intel-xe
mailing list