✗ CI.checkpatch: warning for drm/xe: Add missing runtime outer protection
Patchwork
patchwork at emeril.freedesktop.org
Wed May 29 23:23:27 UTC 2024
== Series Details ==
Series: drm/xe: Add missing runtime outer protection
URL : https://patchwork.freedesktop.org/series/134211/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 80bc3caadc742fab95770aef0f25a0e8575afe08
Author: Rodrigo Vivi <rodrigo.vivi at intel.com>
Date: Wed May 29 17:56:03 2024 -0400
drm/xe: Add missing runtime outer protection
TTM BO destroy is called unlocked as a ref count worker when it
gets 0 users. When that happens we could be runtime suspended,
and waking up from inner locked places like ggtt_remove_node,
could potentially lead to deadlocks. Our warning system against
this case hit this case:
[ 2295.891269] xe 0000:03:00.0: Missing outer runtime PM protection
[snip]
[ 2295.891604] ? xe_pm_runtime_get_noresume+0x5c/0x70 [xe]
[ 2295.891717] ? report_bug+0x18d/0x1c0
[ 2295.891722] ? handle_bug+0x3c/0x80
[ 2295.891724] ? exc_invalid_op+0x13/0x60
[ 2295.891726] ? asm_exc_invalid_op+0x16/0x20
[ 2295.891730] ? xe_pm_runtime_get_noresume+0x5c/0x70 [xe]
[ 2295.891816] xe_ggtt_remove_node+0x93/0xf0 [xe]
[ 2295.891870] xe_ttm_bo_destroy+0xe9/0xf0 [xe]
[ 2295.891935] process_one_work+0x225/0x730
[ 2295.891940] worker_thread+0x1d8/0x3c0
Add this outer protection to avoid any potential deadlock.
Reported-by: Paulo Zanoni <paulo.zanoni at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 55d6179b96e0390025f2ba101c03b94b50cab7a1 drm-intel
80bc3caadc74 drm/xe: Add missing runtime outer protection
-:30: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#30:
Reported-by: Paulo Zanoni <paulo.zanoni at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
More information about the Intel-xe
mailing list