[PATCH] drm/xe: Improve LNL work-queue flush WA warning message

Lucas De Marchi lucas.demarchi at intel.com
Mon Nov 4 14:16:55 UTC 2024


On Mon, Nov 04, 2024 at 10:07:55AM +0100, Nirmoy Das wrote:
>Improve the LNL work-queue flush WA warning message to avoid giving a
>false impression of normal operation.

it's already a warning, meant to be temporary. I'm worried that if we
keep polishing it we won't actually get to the bottom of this issue.

Lucas De Marchi

>
>Cc: Badal Nilawar <badal.nilawar at intel.com>
>Cc: Matthew Auld <matthew.auld at intel.com>
>Cc: Matthew Brost <matthew.brost at intel.com>
>Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Suggested-by: John Harrison <John.C.Harrison at Intel.com>
>Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
>---
> drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
>index a405b9218ad2..63a476ba1e00 100644
>--- a/drivers/gpu/drm/xe/xe_guc_ct.c
>+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
>@@ -1021,7 +1021,7 @@ static int guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
> 	if (!ret) {
> 		LNL_FLUSH_WORK(&ct->g2h_worker);
> 		if (g2h_fence.done) {
>-			xe_gt_warn(gt, "G2H fence %u, action %04x, done\n",
>+			xe_gt_warn(gt, "G2H fence %u, action %04x, done but required a flush\n",
> 				   g2h_fence.seqno, action[0]);
> 			ret = 1;
> 		}
>-- 
>2.46.0
>


More information about the Intel-xe mailing list