[PATCH] drm/xe: Use lowercase for asserts

Lucas De Marchi lucas.demarchi at intel.com
Tue Nov 5 07:17:18 UTC 2024


On Mon, Nov 04, 2024 at 04:05:43PM +0100, Michal Wajdeczko wrote:
>
>
>On 04.11.2024 15:08, Lucas De Marchi wrote:
>> The rendered html documentation for "Xe ASSERTs" doesn't look nice with
>> the mixed caps and gives the impression it was a typo. Just use
>> lowercase to improve it.
>
>some background: in initial version those assert macros were named
>xe_ASSERT() to follow the drm_WARN() style, hence this leftover
>
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_assert.h              | 8 ++++----
>>  drivers/gpu/drm/xe/xe_gt_sriov_pf_helpers.h | 2 +-
>>  drivers/gpu/drm/xe/xe_sriov_pf_helpers.h    | 2 +-
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_assert.h b/drivers/gpu/drm/xe/xe_assert.h
>> index 04d6b95c6d878..831cb62107496 100644
>> --- a/drivers/gpu/drm/xe/xe_assert.h
>> +++ b/drivers/gpu/drm/xe/xe_assert.h
>> @@ -14,7 +14,7 @@
>>  #include "xe_step.h"
>>
>>  /**
>> - * DOC: Xe ASSERTs
>> + * DOC: Xe asserts
>
>nit: maybe this should follow Title Case Style, so this would be:
>
>  * DOC: Xe Asserts
>
>but up to you,
>
>Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

Ok, I changed it and re-submitted. Thanks

Lucas De Marchi


More information about the Intel-xe mailing list