[PATCH v1] drm/xe/guc: Remove duplicate source field

[Teres Alexis, Alan Previn]

On Wed, 2024-11-06 at 15:27 -0800, Zhanjun Dong wrote:
> xe_hw_engine_snapshot.source save the information of where data copied
> from. Because it should always equal to the source of the matched node,
> this field is duplicate data, therefor could be optimized out.
alan: nit: some additional clarification:
"Because the 'source' field is already populated inside 'matched_node' ptr hanging off
xe_devcoredump_snapshot, which happenned either in guc_capture_extract_reglists or xe_engine_manual_capture, 
we can remove this redundant copy of 'source' from xe_hw_engine_snapshot.

alan: comment only: I notice that you removed the assert of the range of source in devcoredump's
matched_node, but since the population is already correct in the only two functions
that could ever generate the matched_node, we can remove that check.

Thus:
Reviewed-by: Alan Previn <alan.previn.teres.alexis at intel.com>