✗ CI.checkpatch: warning for drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD (rev3)
URL   : https://patchwork.freedesktop.org/series/140283/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 2f25f61af1a89141a7d6b508dce93d82855b5672
Author: Gustavo Sousa <gustavo.sousa at intel.com>
Date:   Thu Nov 7 15:27:23 2024 -0300

    drm/i915/xe3lpd: Use DMC wakelock by default
    
    Although Bspec doesn't explicitly mentions that, as of Xe3_LPD, using
    DMC wakelock is the officially recommended way of accessing registers
    that would be off during DC5/DC6 and the legacy method (where the DMC
    intercepts MMIO to wake up the hardware) is to be avoided.
    
    As such, update the driver to use the DMC wakelock by default starting
    with Xe3_LPD. Since the feature is somewhat new to the driver, also
    allow disabling it via a module parameter for debugging purposes.
    
    For that, make the existing parameter allow values -1 (per-chip
    default), 0 (disabled) and 1 (enabled), similarly to what is done for
    other parameters.
    
    v2:
      - Describe -1 in the same area where 0 and 1 are described. (Luca)
    
    Reviewed-by: Luca Coelho <luciano.coelho at intel.com>
    Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
+ /mt/dim checkpatch 85b1b17ed748e1f68ac83052916a95d624405c97 drm-intel
8238085e6f46 drm/i915/dmc_wl: Use i915_mmio_reg_offset() instead of reg.reg
4c6e899676d7 drm/xe: Mimic i915 behavior for non-sleeping MMIO wait
59ee792f86f7 drm/i915/dmc_wl: Use non-sleeping variant of MMIO wait
6fe4d1e08bd5 drm/i915/dmc_wl: Check for non-zero refcount in release work
6ad84c1a879d drm/i915/dmc_wl: Get wakelock when disabling dynamic DC states
dc64289bf910 drm/i915/dmc_wl: Use sentinel item for range tables
303240c66902 drm/i915/dmc_wl: Extract intel_dmc_wl_reg_in_range()
f0e1d4094508 drm/i915/dmc_wl: Rename lnl_wl_range to powered_off_ranges
1c951efdb8f7 drm/i915/dmc_wl: Track registers touched by the DMC
3b463fe8babd drm/i915/dmc_wl: Allow simpler syntax for single reg in range tables
84f5fdd188a2 drm/i915/dmc_wl: Deal with existing references when disabling
808e0a51129b drm/i915/dmc_wl: Couple enable/disable with dynamic DC states
4dac5c0d026c drm/i915/dmc_wl: Add and use HAS_DMC_WAKELOCK()
68d73856a91f drm/i915/dmc_wl: Init only after we have runtime device info
2aa754996c7d drm/i915/dmc_wl: Use HAS_DMC() in HAS_DMC_WAKELOCK()
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:150:
+#define HAS_DMC_WAKELOCK(i915)		(HAS_DMC(i915) && DISPLAY_VER(i915) >= 20)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
26dab0d98f28 drm/i915/dmc_wl: Sanitize enable_dmc_wl according to hardware support
98ae1b18db0e drm/i915/dmc_wl: Do nothing until initialized
2f25f61af1a8 drm/i915/xe3lpd: Use DMC wakelock by default
-:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#35: FILE: drivers/gpu/drm/i915/display/intel_display_params.c:127:
+intel_display_param_named_unsafe(enable_dmc_wl, int, 0400,
 	"Enable DMC wakelock "

total: 0 errors, 0 warnings, 1 checks, 33 lines checked