✗ CI.checkpatch: warning for drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD (rev4)

Patchwork patchwork at emeril.freedesktop.org
Fri Nov 8 13:09:51 UTC 2024


== Series Details ==

Series: drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD (rev4)
URL   : https://patchwork.freedesktop.org/series/140283/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ab515c7d6ac04646f0bb9c6ae35eb5517b3229af
Author: Gustavo Sousa <gustavo.sousa at intel.com>
Date:   Fri Nov 8 09:57:20 2024 -0300

    drm/i915/xe3lpd: Use DMC wakelock by default
    
    Although Bspec doesn't explicitly mentions that, as of Xe3_LPD, using
    DMC wakelock is the officially recommended way of accessing registers
    that would be off during DC5/DC6 and the legacy method (where the DMC
    intercepts MMIO to wake up the hardware) is to be avoided.
    
    As such, update the driver to use the DMC wakelock by default starting
    with Xe3_LPD. Since the feature is somewhat new to the driver, also
    allow disabling it via a module parameter for debugging purposes.
    
    For that, make the existing parameter allow values -1 (per-chip
    default), 0 (disabled) and 1 (enabled), similarly to what is done for
    other parameters.
    
    v2:
      - Describe -1 in the same area where 0 and 1 are described. (Luca)
    
    Reviewed-by: Luca Coelho <luciano.coelho at intel.com>
    Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
+ /mt/dim checkpatch 5521311ecd7ffbb0adf016dbf83bd0165fc94d25 drm-intel
3699e754be0f drm/i915/dmc_wl: Use i915_mmio_reg_offset() instead of reg.reg
a5ff63bde768 drm/xe: Mimic i915 behavior for non-sleeping MMIO wait
95991032bfca drm/i915/dmc_wl: Use non-sleeping variant of MMIO wait
82ccb7651e0c drm/i915/dmc_wl: Check for non-zero refcount in release work
e9490040cb2a drm/i915/dmc_wl: Get wakelock when disabling dynamic DC states
72a50787302c drm/i915/dmc_wl: Use sentinel item for range tables
0d8890cfaade drm/i915/dmc_wl: Extract intel_dmc_wl_reg_in_range()
be874f0f38b1 drm/i915/dmc_wl: Rename lnl_wl_range to powered_off_ranges
7ca99332dbea drm/i915/dmc_wl: Track registers touched by the DMC
f8121aea1721 drm/i915/dmc_wl: Allow simpler syntax for single reg in range tables
ca3dbfb5b8d2 drm/i915/dmc_wl: Deal with existing references when disabling
6fd5c1f3a9b8 drm/i915/dmc_wl: Couple enable/disable with dynamic DC states
61e13c4fdb28 drm/i915/dmc_wl: Add and use HAS_DMC_WAKELOCK()
903ccf259033 drm/i915/dmc_wl: Sanitize enable_dmc_wl according to hardware support
ab515c7d6ac0 drm/i915/xe3lpd: Use DMC wakelock by default
-:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#35: FILE: drivers/gpu/drm/i915/display/intel_display_params.c:127:
+intel_display_param_named_unsafe(enable_dmc_wl, int, 0400,
 	"Enable DMC wakelock "

total: 0 errors, 0 warnings, 1 checks, 33 lines checked




More information about the Intel-xe mailing list