[PATCH 7/7] drm/xe: Wire devcoredump to LR TDR

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Matthew Brost
Sent: Friday, November 8, 2024 9:43 AM
To: intel-xe at lists.freedesktop.org
Cc: Teres Alexis, Alan Previn <alan.previn.teres.alexis at intel.com>; Dong, Zhanjun <zhanjun.dong at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>
Subject: [PATCH 7/7] drm/xe: Wire devcoredump to LR TDR
> 
> LR queue's can hang, cause engine reset, or cause IOMMU CAT errors.
> Collect an error capture when this occurs.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>

s/queue's/queues
Otherwise, LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 3df8543deec1..a52e56ea42df 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -901,6 +901,7 @@ static void xe_guc_exec_queue_lr_cleanup(struct work_struct *w)
>  					 !exec_queue_pending_disable(q) ||
>  					 xe_guc_read_stopped(guc), HZ * 5);
>  		if (!ret) {
> +			xe_devcoredump(q, NULL);
>  			drm_warn(&xe->drm, "Schedule disable failed to respond");
>  			xe_sched_submission_start(sched);
>  			xe_gt_reset_async(q->gt);
> @@ -908,6 +909,9 @@ static void xe_guc_exec_queue_lr_cleanup(struct work_struct *w)
>  		}
>  	}
>  
> +	if (!exec_queue_killed(q) && !xe_lrc_ring_is_idle(q->lrc[0]))
> +		xe_devcoredump(q, NULL);
> +
>  	xe_sched_submission_start(sched);
>  }
>  
> -- 
> 2.34.1
> 
>