[PATCH 1/2] platform/x86/intel/pmt: allow user offset for PMT callbacks

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Nov 11 08:34:14 UTC 2024


On Fri, Nov 08, 2024 at 03:19:53PM -0500, Michael J. Ruhl wrote:
> Usage of the telem sysfs file allows for partial reads at
> an offset.
> 
> The current callback method returns the buffer starting
> from offset 0 only.
> 
> Include the requested offset in the callback.
> Update the necsessary address calculations with the offset.

...

> -	memcpy_fromio(buf, addr, count);
> +	memcpy_fromio(buf, addr + off, count);

This will give an unaligned IO access in some cases. Is it a problem?

-- 
With Best Regards,
Andy Shevchenko




More information about the Intel-xe mailing list