✗ CI.checkpatch: warning for drm/i915/mst: cleanups, renames, clarifications (rev3)

Patchwork patchwork at emeril.freedesktop.org
Tue Nov 12 11:22:32 UTC 2024


== Series Details ==

Series: drm/i915/mst: cleanups, renames, clarifications (rev3)
URL   : https://patchwork.freedesktop.org/series/141067/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 245017272916ce95f2f257fb732f548bf260ebe9
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Tue Nov 12 13:10:44 2024 +0200

    drm/i915/dp: add comments about hooks called from MST stream encoders
    
    It would be best to have self-explanatory code, but lacking that, add
    some comments about the way the DDI encoder hooks get called from DP MST
    stream encoders.
    
    Reviewed-by: Imre Deak <imre.deak at intel.com>
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 2039b778888dca4061a04cb38357e0b5f930b93e drm-intel
07785472de3b drm/i915/mst: pass primary encoder to primary encoder hooks
-:22: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#22: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:1116:
+		dig_port->base.post_pll_disable(state, &dig_port->base, old_crtc_state, old_conn_state);

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
a67d608e7e94 drm/i915/mst: rename intel_encoder to encoder
53d0a5297415 drm/i915/mst: introduce to_primary_encoder() and to_primary_dp()
-:154: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#154: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:1126:
+		primary_encoder->post_pll_disable(state, primary_encoder, old_crtc_state, old_conn_state);

total: 0 errors, 1 warnings, 0 checks, 231 lines checked
b61127a96afc drm/i915/mst: use primary_encoder in fake mst encoder creation
86c6f645289a drm/i915/display: make CHICKEN_TRANS() display version aware
-:227: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#227: FILE: drivers/gpu/drm/i915/i915_reg.h:2758:
+#define _CHICKEN_TRANS(trans)	_MMIO(_PICK((trans), \
 					    [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \
 					    [TRANSCODER_A] = _CHICKEN_TRANS_A, \
 					    [TRANSCODER_B] = _CHICKEN_TRANS_B, \

-:239: WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#239: FILE: drivers/gpu/drm/i915/i915_reg.h:2769:
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))

-:239: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'trans' - possible side-effects?
#239: FILE: drivers/gpu/drm/i915/i915_reg.h:2769:
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))

total: 1 errors, 1 warnings, 1 checks, 176 lines checked
9c98d79f0ae0 drm/i915/mst: convert to struct intel_display
b4b2a2f35f2c drm/i915/mst: change naming from fake encoders to MST stream encoders
245017272916 drm/i915/dp: add comments about hooks called from MST stream encoders




More information about the Intel-xe mailing list