✗ CI.checkpatch: warning for Add PMU support for single engine busyness

Patchwork patchwork at emeril.freedesktop.org
Wed Nov 13 14:42:23 UTC 2024


== Series Details ==

Series: Add PMU support for single engine busyness
URL   : https://patchwork.freedesktop.org/series/141259/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b9be4b851151abcfed841754b1825fb5748d2bd7
Author: Riana Tauro <riana.tauro at intel.com>
Date:   Wed Nov 13 10:25:49 2024 +0530

    drm/xe/pmu: Add PMU support for engine busyness
    
    PMU provides two counters (<engine>-busy-ticks-gt<n>,
    <engine>-total-ticks-gt<n>) to calculate engine busyness. When querying
    engine busyness, user must group these 2 counters using the perf_event
    group mechanism to ensure both counters are sampled together.
    
    To list engine busyness counters use the following
    
    ./perf list
      xe_0000_03_00.0/bcs0-busy-ticks-gt0/               [Kernel PMU event]
      xe_0000_03_00.0/bcs0-total-ticks-gt0/              [Kernel PMU event]
      xe_0000_03_00.0/ccs0-busy-ticks-gt0/               [Kernel PMU event]
      xe_0000_03_00.0/ccs0-total-ticks-gt0/              [Kernel PMU event]
    
    Engine busyness can then be calculated as below
    busyness % = (engine active ticks/total ticks) * 100
    
    Signed-off-by: Riana Tauro <riana.tauro at intel.com>
+ /mt/dim checkpatch 169c7cd31a373ed31054abb423981856eb5fb119 drm-intel
8521954a3a04 drm/xe/pmu: Enable PMU interface
-:25: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately followed by Signed-off-by:
#25: 
Co-developed-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
Co-developed-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>

-:26: WARNING:BAD_SIGN_OFF: Co-developed-by and Signed-off-by: name/email do not match
#26: 
Co-developed-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>

-:117: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#117: 
new file mode 100644

total: 0 errors, 3 warnings, 0 checks, 734 lines checked
24d713a16e87 drm/xe/pmu: Add GT C6 events
aecffc8f4fd3 drm/xe/pmu: Add GT frequency events
b4fccfc0b661 drm/xe: add function to convert xe hw engine class to user class
e5167dd37fc3 drm/xe: Add single engine busyness support
-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

-:511: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#511: FILE: drivers/gpu/drm/xe/xe_guc_fwif.h:220:
+	struct guc_engine_activity engine_activity[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];

total: 0 errors, 2 warnings, 0 checks, 483 lines checked
6a9c01626e42 drm/xe/guc: Expose engine busyness only for supported GuC version
b9be4b851151 drm/xe/pmu: Add PMU support for engine busyness




More information about the Intel-xe mailing list