[PATCH v6 1/3] drm/xe/pmu: Enable PMU interface

Lucas De Marchi lucas.demarchi at intel.com
Thu Nov 14 15:26:24 UTC 2024


On Wed, Nov 13, 2024 at 08:33:52PM -0800, Ashutosh Dixit wrote:
>On Wed, 13 Nov 2024 19:16:55 -0800, Lucas De Marchi wrote:
>>
>> > diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
>> > index bccca63c8a48..0cb8d650135a 100644
>> > --- a/drivers/gpu/drm/xe/xe_device_types.h
>> > +++ b/drivers/gpu/drm/xe/xe_device_types.h
>> > @@ -18,6 +18,7 @@
>> > #include "xe_memirq_types.h"
>> > #include "xe_oa.h"
>> > #include "xe_platform_types.h"
>> > +#include "xe_pmu.h"
>>
>> you will need a xe_pmu_types.h where you only define the types.
>> See the other lines that serve as good citizens, don't look at xe_oa.h
>
>What's wrong with xe_oa.h :) There's an xe_oa_types.h!

you might as well use that header ;). I just sent a trivial series
fixing a few pre-existent issues I noticed while reviewing this:

https://lore.kernel.org/intel-xe/20241114152148.572447-1-lucas.demarchi@intel.com/

Lucas De Marchi


More information about the Intel-xe mailing list