✗ CI.checkpatch: warning for Add PMU support for single engine busyness (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 21 06:34:10 UTC 2024


== Series Details ==

Series: Add PMU support for single engine busyness (rev2)
URL   : https://patchwork.freedesktop.org/series/141259/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ada0bac76e3f883431654a8be420cf714f1f8eee
Author: Riana Tauro <riana.tauro at intel.com>
Date:   Thu Nov 21 12:09:04 2024 +0530

    drm/xe/pmu: Add PMU support for engine busyness
    
    PMU provides two counters (<engine>-busy-ticks-gt<n>,
    <engine>-total-ticks-gt<n>) to calculate engine busyness. When querying
    engine busyness, user must group these 2 counters using the perf_event
    group mechanism to ensure both counters are sampled together.
    
    To list engine busyness counters use the following
    
    ./perf list
      xe_0000_03_00.0/bcs0-busy-ticks-gt0/               [Kernel PMU event]
      xe_0000_03_00.0/bcs0-total-ticks-gt0/              [Kernel PMU event]
      xe_0000_03_00.0/ccs0-busy-ticks-gt0/               [Kernel PMU event]
      xe_0000_03_00.0/ccs0-total-ticks-gt0/              [Kernel PMU event]
    
    Engine busyness can then be calculated as below
    busyness % = (engine active ticks/total ticks) * 100
    
    Signed-off-by: Riana Tauro <riana.tauro at intel.com>
+ /mt/dim checkpatch e46649e7764a9f6868ccbcba7b8b23b413303380 drm-intel
b8aef603a61e drm/xe/pmu: Enable PMU interface
-:117: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#117: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 734 lines checked
a430a5e1b1b5 drm/xe/pmu: Add GT C6 events
70fb48bb38da drm/xe/pmu: Add GT frequency events
4578d302380f drm/xe: add function to convert xe hw engine class to user class
291c2c9a76b5 drm/xe: Add single engine busyness support
-:60: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

-:520: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#520: FILE: drivers/gpu/drm/xe/xe_guc_fwif.h:220:
+	struct guc_engine_activity engine_activity[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];

total: 0 errors, 2 warnings, 0 checks, 489 lines checked
54a038ab51da drm/xe/trace: Add trace for xe_engine_activity
-:71: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#71: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:109:
+	    TP_STRUCT__entry(

-:88: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#88: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:126:
+	    TP_fast_assign(

total: 0 errors, 0 warnings, 2 checks, 90 lines checked
0d21053f078f drm/xe/guc: Expose engine busyness only for supported GuC version
ada0bac76e3f drm/xe/pmu: Add PMU support for engine busyness




More information about the Intel-xe mailing list