[PATCH 0/8] Display Global Histogram

Murthy, Arun R arun.r.murthy at intel.com
Thu Nov 21 14:13:36 UTC 2024


Hi Daniel,

> On Thu, 21 Nov 2024 at 12:35, Arun R Murthy <arun.r.murthy at intel.com>
> wrote:
> > The corresponding mutter changes to enable/disable histogram, read the
> > histogram data, communicate with the library and write the enhanced
> > data back to the KMD is also pushed for review at
> > https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3873
> 
> Again, the Mutter MR which is linked does _not_ write anything back to the
> KMS driver. It would be much more clear to explain in your cover letters that it
> currently reads the histogram values and does nothing with them, and that an
> expected next step is to make it write the processed values back to the KMS
> driver. Even though I'm sure your intention is not to mislead anyone, what you
> are writing here is not actually true.
> 
I am sorry for that.
I totally agree that  without writing back the enhanced data back to the KMD, the feature is incomplete. Will update the mutter changes so as to include the KMD write part in a day or two.

Thanks and Regards,
Arun R Murthy
--------------------
-------------- next part --------------
An embedded message was scrubbed...
From: "Kandpal, Suraj" <suraj.kandpal at intel.com>
Subject: RE: [PATCHv5 2/8] drm/i915/histogram: Add support for histogram
Date: Thu, 21 Nov 2024 13:44:14 +0000
Size: 19716
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20241121/faaabd0f/attachment-0001.eml>


More information about the Intel-xe mailing list