✓ CI.checkpatch: success for drm/xe: Add devcoredump locking and reason string (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Tue Nov 26 04:10:45 UTC 2024
== Series Details ==
Series: drm/xe: Add devcoredump locking and reason string (rev4)
URL : https://patchwork.freedesktop.org/series/141628/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 77bc7d62298b602def845c84a920da7f6c339f0d
Author: John Harrison <John.C.Harrison at Intel.com>
Date: Mon Nov 25 19:44:11 2024 -0800
drm/xe: Add mutex locking to devcoredump
There are now multiple places that can trigger a coredump. Some of
which can happen in parallel. There is already a check against
capturing multiple dumps sequentially, but without locking it doesn't
guarantee to work against concurrent dumps. And if two dumps do happen
in parallel, they can end up doing Bad Things such as one call stack
freeing the data the other call stack is still processing. Which leads
to a crashed kernel.
Further, it is possible for the DRM timeout to expire and trigger a
free of the capture while a user is still reading that capture out
through sysfs. Again leading to dodgy pointer problems.
So, add a mutext lock around the capture, read and free functions to
prevent inteference.
v2: Swap tiny scope spin_lock for larger scope mutex and fix
kernel-doc comment (review feedback from Matthew Brost)
v3: Move mutex locks to exclude worker thread and add reclaim
annotation (review feedback from Matthew Brost)
v4: Fix typo.
Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch ae312905c5a9fc7ce599a74422f068725101c475 drm-intel
8afd196070f1 drm/xe: Add a reason string to the devcoredump
77bc7d62298b drm/xe: Add mutex locking to devcoredump
More information about the Intel-xe
mailing list