✗ CI.checkpatch: warning for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev4)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev4)
URL   : https://patchwork.freedesktop.org/series/137985/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fc7727292de201fa58457403db241a167b1f3cf3
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Thu Sep 19 20:21:08 2024 -0700

    drm/xe/guc: Add a helper function for dumping GuC log to dmesg
    
    Create a helper function that can be used to dump the GuC log to dmesg
    in a manner that is reliable for extraction and decode. The intention
    is that calls to this can be added by developers when debugging
    specific issues that require a GuC log but do not allow easy capture
    of the log - e.g. failures in selftests and failues that lead to
    kernel hangs.
    
    Also note that this is really a temporary stop-gap. The aim is to
    allow on demand creation and dumping of devcoredump captures (which
    includes the GuC log and much more). Currently this is not possible as
    much of the devcoredump code requires a 'struct xe_sched_job' and
    those are not available at many places that might want to do the dump.
    
    v2: Add kerneldoc - review feedback from Michal W.
    
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch 4e4d7873ac763aa0bd9207ea9ec2b89bb52a6fe1 drm-intel
4763fb335f94 drm/xe/guc: Remove spurious line feed in debug print
b23d5e37e925 drm/xe/devcoredump: Use drm_puts and already cached local variables
d3872325ccb2 drm/xe/devcoredump: Improve section headings and add tile info
9b500f4b8c94 drm/xe/devcoredump: Add ASCII85 dump helper function
ad85121396fd drm/xe/guc: Copy GuC log prior to dumping
723207ea73c4 drm/xe/guc: Use a two stage dump for GuC logs and add more info
4373507fd059 drm/print: Introduce drm_line_printer
3a1d80b32d7c drm/xe/guc: Dead CT helper
-:99: WARNING:MACRO_ARG_UNUSED: Argument 'ct' is not used in function-like macro
#99: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

-:99: WARNING:MACRO_ARG_UNUSED: Argument 'reason' is not used in function-like macro
#99: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

total: 0 errors, 2 warnings, 0 checks, 559 lines checked
ee93fb22a1cf drm/xe/guc: Dump entire CTB on errors
c0b057303d07 drm/xe/guc: Add GuC log to devcoredump captures
fc7727292de2 drm/xe/guc: Add a helper function for dumping GuC log to dmesg