✗ CI.checkpatch: warning for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev5)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev5)
URL   : https://patchwork.freedesktop.org/series/137985/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b457795128f10d0ae6c41373c3e6469258a7869b
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Wed Oct 2 14:14:22 2024 -0700

    drm/xe/guc: Add a helper function for dumping GuC log to dmesg
    
    Create a helper function that can be used to dump the GuC log to dmesg
    in a manner that is reliable for extraction and decode. The intention
    is that calls to this can be added by developers when debugging
    specific issues that require a GuC log but do not allow easy capture
    of the log - e.g. failures in selftests and failues that lead to
    kernel hangs.
    
    Also note that this is really a temporary stop-gap. The aim is to
    allow on demand creation and dumping of devcoredump captures (which
    includes the GuC log and much more). Currently this is not possible as
    much of the devcoredump code requires a 'struct xe_sched_job' and
    those are not available at many places that might want to do the dump.
    
    v2: Add kerneldoc - review feedback from Michal W.
    
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch 789d5631453c3edad1988cd47db1643555e52ac9 drm-intel
2b66b94c6f47 drm/xe/guc: Remove spurious line feed in debug print
076f9d38216e drm/xe/devcoredump: Use drm_puts and already cached local variables
d38d194ac57e drm/xe/devcoredump: Improve section headings and add tile info
58e588bab814 drm/xe/devcoredump: Add ASCII85 dump helper function
059aee99c9d8 drm/xe/guc: Copy GuC log prior to dumping
56d1762b790a drm/xe/guc: Use a two stage dump for GuC logs and add more info
1158d15e6718 drm/print: Introduce drm_line_printer
4fdede82017a drm/xe/guc: Dead CT helper
-:102: WARNING:MACRO_ARG_UNUSED: Argument 'ct' is not used in function-like macro
#102: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

-:102: WARNING:MACRO_ARG_UNUSED: Argument 'reason' is not used in function-like macro
#102: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

total: 0 errors, 2 warnings, 0 checks, 572 lines checked
5bc232d0885d drm/xe/guc: Dump entire CTB on errors
bec4246c9fba drm/xe/guc: Add GuC log to devcoredump captures
b457795128f1 drm/xe/guc: Add a helper function for dumping GuC log to dmesg