✗ CI.checkpatch: warning for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev6)

[Patchwork]

== Series Details ==

Series: drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev6)
URL   : https://patchwork.freedesktop.org/series/137985/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1a659096ff84523d626712cb0fbc9e0d7f75f148
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Wed Oct 2 17:46:11 2024 -0700

    drm/xe/guc: Add a helper function for dumping GuC log to dmesg
    
    Create a helper function that can be used to dump the GuC log to dmesg
    in a manner that is reliable for extraction and decode. The intention
    is that calls to this can be added by developers when debugging
    specific issues that require a GuC log but do not allow easy capture
    of the log - e.g. failures in selftests and failues that lead to
    kernel hangs.
    
    Also note that this is really a temporary stop-gap. The aim is to
    allow on demand creation and dumping of devcoredump captures (which
    includes the GuC log and much more). Currently this is not possible as
    much of the devcoredump code requires a 'struct xe_sched_job' and
    those are not available at many places that might want to do the dump.
    
    v2: Add kerneldoc - review feedback from Michal W.
    
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Julia Filipchuk <julia.filipchuk at intel.com>
+ /mt/dim checkpatch 789d5631453c3edad1988cd47db1643555e52ac9 drm-intel
1f52e9c74298 drm/xe/guc: Remove spurious line feed in debug print
5c50bfc655d1 drm/xe/devcoredump: Use drm_puts and already cached local variables
d51bd635f9ae drm/xe/devcoredump: Improve section headings and add tile info
61ba929a67d4 drm/xe/devcoredump: Add ASCII85 dump helper function
ff9336288e5d drm/xe/guc: Copy GuC log prior to dumping
c695211b3877 drm/xe/guc: Use a two stage dump for GuC logs and add more info
df7b40d195e1 drm/print: Introduce drm_line_printer
b29fe4681358 drm/xe/guc: Dead CT helper
-:102: WARNING:MACRO_ARG_UNUSED: Argument 'ct' is not used in function-like macro
#102: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

-:102: WARNING:MACRO_ARG_UNUSED: Argument 'reason' is not used in function-like macro
#102: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:62:
+#define CT_DEAD(ct, ctb, reason)			\
+	do {						\
+		struct guc_ctb *_ctb = (ctb);		\
+		if (_ctb)				\
+			_ctb->info.broken = true;	\
+	} while (0)

-:365: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#365: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:1333:
+		/*
+		u32 desc_head = desc_read(xe, g2h, head);

total: 0 errors, 3 warnings, 0 checks, 572 lines checked
ccde8ddbd2d3 drm/xe/guc: Dump entire CTB on errors
3645fbe99c16 drm/xe/guc: Add GuC log to devcoredump captures
1a659096ff84 drm/xe/guc: Add a helper function for dumping GuC log to dmesg