[PATCH] drm/xe: Make wedged_mode debugfs writable

Gustavo Sousa gustavo.sousa at intel.com
Thu Oct 3 20:27:35 UTC 2024


Quoting Matt Roper (2024-10-02 20:06:21-03:00)
>The intent of this debugfs entry is to allow modification of wedging
>behavior, either from IGT tests or during manual debug; it should be
>marked as writable to properly reflect this.  In practice this hasn't
>caused a problem because we always access wedged_mode as root, which
>ignores file permissions, but it's still misleading to have the entry
>incorrectly marked as RO.
>
>Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>Fixes: 6b8ef44cc0a9 ("drm/xe: Introduce the wedged_mode debugfs")
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>

>---
> drivers/gpu/drm/xe/xe_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
>index 668615c6b172..fe4319eb13fd 100644
>--- a/drivers/gpu/drm/xe/xe_debugfs.c
>+++ b/drivers/gpu/drm/xe/xe_debugfs.c
>@@ -187,7 +187,7 @@ void xe_debugfs_register(struct xe_device *xe)
>         debugfs_create_file("forcewake_all", 0400, root, xe,
>                             &forcewake_all_fops);
> 
>-        debugfs_create_file("wedged_mode", 0400, root, xe,
>+        debugfs_create_file("wedged_mode", 0600, root, xe,
>                             &wedged_mode_fops);
> 
>         for (mem_type = XE_PL_VRAM0; mem_type <= XE_PL_VRAM1; ++mem_type) {
>-- 
>2.46.2
>


More information about the Intel-xe mailing list