✓ CI.checkpatch: success for drm/xe: Log unreliable MMIO reads during forcewake (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Thu Oct 17 22:58:36 UTC 2024
== Series Details ==
Series: drm/xe: Log unreliable MMIO reads during forcewake (rev4)
URL : https://patchwork.freedesktop.org/series/139922/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 020ea59ada108f783d7515311b967e787d2614c6
Author: Shuicheng Lin <shuicheng.lin at intel.com>
Date: Thu Oct 17 22:15:47 2024 +0000
drm/xe: Handle unreliable MMIO reads during forcewake
In some cases, when the driver attempts to read an MMIO register,
the hardware may return 0xFFFFFFFF. The current force wake path
code treats this as a valid response, as it only checks the BIT.
However, 0xFFFFFFFF should be considered an invalid value, indicating
a potential issue. To address this, we should add a log entry to
highlight this condition and return failure.
The force wake failure log level is changed from notice to err
to match the failure return value.
v2 (Matt Brost):
- set ret value (-EIO) to kick the error to upper layers
v3 (Rodrigo):
- add commit message for the log level promotion from notice to err
v4:
- update reviewed info
Suggested-by: Alex Zuo <alex.zuo at intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
Acked-by: Badal Nilawar <badal.nilawar at intel.com>
Cc: Anshuman Gupta <anshuman.gupta at intel.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 4a1a4fc678a06046ca0443a2d0d61f2174c56b1d drm-intel
020ea59ada10 drm/xe: Handle unreliable MMIO reads during forcewake
More information about the Intel-xe
mailing list