[PATCH topic/xe-for-ci] drm/xe/ptl: Add GuC firmware definition

Lucas De Marchi lucas.demarchi at intel.com
Fri Oct 18 21:14:23 UTC 2024


On Fri, Oct 11, 2024 at 10:01:41PM -0500, Lucas De Marchi wrote:
>and actually Cc John.
>
>Lucas De Marchi
>
>On Fri, Oct 11, 2024 at 09:58:15PM -0500, Lucas De Marchi wrote:
>>On Fri, Oct 11, 2024 at 09:39:20AM -0700, Matt Atwood wrote:
>>>From: Clint Taylor <clinton.a.taylor at intel.com>
>>>
>>>Define the GuC firmware to load on the platform.
>>>
>>>Signed-off-by: Clint Taylor <clinton.a.taylor at intel.com>
>>>Signed-off-by: Matt Atwood <matthew.s.atwood at intel.com>
>>
>>+John
>>
>>We can't apply this until the firmware is available at
>>https://gitlab.com/kernel-firmware/drm-firmware/-/tree/intel-staging?ref_type=heads

so, after some back and forth on the best approach here: let's apply
this patch as is.

I have a patch that allows adding entries in the table behind a build
config, that we can set on CI config. That config would hopefully not be
set by any distros packaging drm-tip, so they wouldn't see any warning
during initramfs creation. However in practice this isn't of much
value:  the warning is non-fatal and anyone looking at drm-tip could
deal with it.  I very much doubt any package is actually following
https://gitlab.com/kernel-firmware/drm-firmware/ for those staging
firmware. First of all because we recently moved it from another repo
and nobody noticed.

On the other hand, adding a config needed by developers means that when
they forget to set it, we will get  a bug report that PTL is not loading
due to missing firmware entry in the table.

So... let's try to keep things simple and fallback to a more complex one
if things don't go as planned.

Applying (soon) to topic/xe-for-ci.

Lucas De Marchi

>>
>>Lucas De Marchi
>>
>>>---
>>>drivers/gpu/drm/xe/xe_uc_fw.c | 1 +
>>>1 file changed, 1 insertion(+)
>>>
>>>diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
>>>index 087fb96f707e..555ba12e0304 100644
>>>--- a/drivers/gpu/drm/xe/xe_uc_fw.c
>>>+++ b/drivers/gpu/drm/xe/xe_uc_fw.c
>>>@@ -107,6 +107,7 @@ struct fw_blobs_by_type {
>>>};
>>>
>>>#define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver)			\
>>>+	fw_def(PANTHERLAKE,	mmp_ver(xe,	guc,	ptl,	70, 33, 2))	\
>>>	fw_def(BATTLEMAGE,	major_ver(xe,	guc,	bmg,	70, 29, 2))	\
>>>	fw_def(LUNARLAKE,	major_ver(xe,	guc,	lnl,	70, 29, 2))	\
>>>	fw_def(METEORLAKE,	major_ver(i915,	guc,	mtl,	70, 29, 2))	\
>>>-- 
>>>2.45.0
>>>


More information about the Intel-xe mailing list