✗ CI.checkpatch: warning for Fix non-contiguous VRAM BO access in Xe (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 18 22:49:47 UTC 2024


== Series Details ==

Series: Fix non-contiguous VRAM BO access in Xe (rev2)
URL   : https://patchwork.freedesktop.org/series/140200/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 332351490107941d8a1ec7e190921b778b0667e3
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Fri Oct 18 14:16:23 2024 -0700

    drm/xe: Use ttm_bo_access in xe_vm_snapshot_capture_delayed
    
    Non-contiguous mapping of BO in VRAM doesn't work, use ttm_bo_access
    instead.
    
    v2:
     - Fix error handling
    
    Fixes: 0eb2a18a8fad ("drm/xe: Implement VM snapshot support for BO's and userptr")
    Suggested-by: Matthew Auld <matthew.auld at intel.com>
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch fe768c9d3f0cfbe30a1dddf3ae2319d1e04a4403 drm-intel
1c581c5cc170 drm/ttm: Add ttm_bo_access
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: Christoph Manszewski <christoph.manszewski at intel.com>
Suggested-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>

-:28: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t'
#28: FILE: drivers/gpu/drm/ttm/ttm_bo_util.c:925:
+			      uint8_t *buf, int len, int write)

-:64: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#64: FILE: drivers/gpu/drm/ttm/ttm_bo_util.c:961:
+}
+/**

-:99: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#99: FILE: drivers/gpu/drm/ttm/ttm_bo_util.c:996:
+			ret = bo->bdev->funcs->access_memory(

total: 0 errors, 1 warnings, 3 checks, 174 lines checked
805ed2c866e3 drm/xe: Add xe_ttm_access_memory
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: Christoph Manszewski <christoph.manszewski at intel.com>
Suggested-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>

total: 0 errors, 1 warnings, 0 checks, 83 lines checked
332351490107 drm/xe: Use ttm_bo_access in xe_vm_snapshot_capture_delayed
-:55: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#55: FILE: drivers/gpu/drm/xe/xe_vm.c:3373:
+			printk("%s:%d: j=%d", __func__, __LINE__, (int)j);

total: 0 errors, 1 warnings, 0 checks, 36 lines checked




More information about the Intel-xe mailing list