[PATCH] drm/xe/xe_guc_ads: save/restore OA registers

[Umesh Nerlige Ramappa]

On Mon, Oct 21, 2024 at 04:19:21PM -0700, Umesh Nerlige Ramappa wrote:
>On Mon, Oct 21, 2024 at 04:11:39PM -0700, Dixit, Ashutosh wrote:
>>On Mon, 21 Oct 2024 15:24:01 -0700, Jonathan Cavitt wrote:
>>>
>>>Several OA registers were missing from the save restore list for GuC and
>>>could be lost during an engine reset.  Add them to the list.
>
>Thanks for isolating this issue. Just a nit here:
>
>OA is just one of the users of the command streamer allow/deny-list 
>regs, so I would just reword this:
>
>s/OA registers/OA registers and allowlist regs/
>
>rest looks good,
>
>Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Responded to the wrong mail. Addressing Jonathon above.

Thanks,
Umesh
>
>
>>>
>>>Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
>>>Suggested-by: John Harrison <john.c.harrison at intel.com>
>>>Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
>>
>>Thanks for chasing this down.
>>
>>Think we should consider this a fix and add:
>>
>>Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2249
>>
>>And also, maybe,
>>
>>Cc: stable at vger.kernel.org
>>
>>For that we may also need a "Fixes:" tag?
>>
>>Acked-by: Ashutosh Dixit <ashutosh.dixit at intel.com>